[Piglit] [PATCH 5/7] framework: remove outdated comment

Nicolai Hähnle nhaehnle at gmail.com
Wed Oct 11 10:12:53 UTC 2017

From: Nicolai Hähnle <nicolai.haehnle at amd.com>

TestrunResult.from_dict is indeed used at the end of the function.
 framework/backends/json.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/framework/backends/json.py b/framework/backends/json.py
index 440202612..882169e09 100644
--- a/framework/backends/json.py
+++ b/framework/backends/json.py
@@ -266,21 +266,20 @@ def _load(results_file):
         raise exceptions.PiglitFatalError(
             'While loading json results file: "{}",\n'
             'the following error occurred:\n{}'.format(results_file.name,
     return result
 def _resume(results_dir):
     """Loads a partially completed json results directory."""
-    # TODO: could probably use TestrunResult.from_dict here
     # Pylint can't infer that the json being loaded is a dict
     # pylint: disable=maybe-no-member
     assert os.path.isdir(results_dir), \
         "TestrunResult.resume() requires a directory"
     # Load the metadata
     with open(os.path.join(results_dir, 'metadata.json'), 'r') as f:
         meta = json.load(f)
     assert meta['results_version'] == CURRENT_JSON_VERSION, \
         "Old results version, resume impossible"

More information about the Piglit mailing list