[Piglit] [PATCH 4/6] framework: remove _DISABLED variable in opengl.py

Dylan Baker dylan at pnwbakers.com
Thu Oct 19 00:39:33 UTC 2017


Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Quoting Brian Paul (2017-10-12 21:23:08)
> Just to simplify the code.
> ---
>  framework/test/opengl.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/framework/test/opengl.py b/framework/test/opengl.py
> index 81de933..94d2f77 100644
> --- a/framework/test/opengl.py
> +++ b/framework/test/opengl.py
> @@ -37,9 +37,6 @@ __all__ = [
>      'FastSkipMixin',
>  ]
>  
> -# An environment variable that when set to true disables the FastSkipMixin by
> -# stubbing it out
> -_DISABLED = bool(os.environ.get('PIGLIT_NO_FAST_SKIP', False))
>  
>  
>  class FastSkip(object):
> @@ -252,7 +249,7 @@ class FastSkipMixinDisabled(object):
>  
>  # Shadow the real FastSkipMixin with the Disabled version if
>  # PIGLIT_NO_FAST_SKIP is truthy
> -if _DISABLED:
> +if bool(os.environ.get('PIGLIT_NO_FAST_SKIP', False)):
>      warnings.warn('Fast Skipping Disabled')
>      # TODO: we can probably get rid of the FastSkipMixinDisabled and just rely
>      # on the FastSkipDisabled
> -- 
> 1.9.1
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20171018/76e093ca/attachment-0001.sig>


More information about the Piglit mailing list