[Piglit] [PATCH 2/4] arb_internalformat_query2: more than one way to support GEOMETRY_TEXTURE

Ilia Mirkin imirkin at alum.mit.edu
Fri Oct 27 17:27:16 UTC 2017


On Fri, Oct 27, 2017 at 5:24 AM, Alejandro PiƱeiro <apinheiro at igalia.com> wrote:
> ---
>  tests/spec/arb_internalformat_query2/common.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_internalformat_query2/common.c b/tests/spec/arb_internalformat_query2/common.c
> index a5686c0a50..f4a30e0286 100644
> --- a/tests/spec/arb_internalformat_query2/common.c
> +++ b/tests/spec/arb_internalformat_query2/common.c
> @@ -617,7 +617,9 @@ check_query2_pname_dependencies(const GLenum pname)
>                  break;
>
>          case GL_GEOMETRY_TEXTURE:
> -                if (!piglit_is_extension_supported("GL_ARB_geometry_shader4"))
> +                if (!piglit_is_extension_supported("GL_ARB_geometry_shader4") &&
> +                    !piglit_is_extension_supported("GL_EXT_geometry_shader") &&

That's for GLES-only, no? And these tests are for desktop only? If it
does include GLES, then you should also add OES_geometry_shader.

> +                    !(piglit_get_gl_version() >= 32))
>                          return false;
>                  break;
>
> --
> 2.11.0
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list