[Piglit] [PATCH] minmax: change the glGet functions to accept 64-bit variables

[Dylan Baker]

According to the ARB_sync spec, in the Issues section:

 29) Should there be an implementation-dependent maximum timeout
        interval?

        RESOLVED: Not for client waits, which may block "forever", but a
        MAX_SERVER_WAIT_TIMEOUT implementation-dependent value exists,
        together with a new GetInteger64v query (see issue 30).
        ...


  30) What is the type of the timeout interval?

        RESOLVED: GLuint64. We previously typedefed uint64_t (or
        equivalent) as 'GLtime', but now that max timeout intervals are
        queriable, a query function is required. A generic query for
        64-bit integer data is more useful than a GLtime-specific query.
        Consequently the type of <timeout> has been changed to
        'GLuint64' and a corresponding 'GetInteger64v' query taking
        'GLint64' added (by symmetry with GetInteger, where unsigned
        quantities are queries with a function taking a pointer to a
        signed integer - the pointer conversion is harmless).
        ...

So I think this should actually use piglit_test_min_uint64

Dylan

Quoting Sandra Koroniewska (2017-09-05 03:25:32)
> This fixes
> spec/gl-3.2/minmax.c and spec/gl-3.3/minmax.c on Windows Intel driver.
> ---
>  tests/spec/gl-3.2/minmax.c | 2 +-
>  tests/spec/gl-3.3/minmax.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/spec/gl-3.2/minmax.c b/tests/spec/gl-3.2/minmax.c
> index e44246f3e..9b96381e6 100644
> --- a/tests/spec/gl-3.2/minmax.c
> +++ b/tests/spec/gl-3.2/minmax.c
> @@ -163,7 +163,7 @@ piglit_init(int argc, char **argv)
>         piglit_test_min_int(GL_MAX_COLOR_TEXTURE_SAMPLES, 1);
>         piglit_test_min_int(GL_MAX_DEPTH_TEXTURE_SAMPLES, 1);
>         piglit_test_min_int(GL_MAX_INTEGER_SAMPLES, 1);
> -       piglit_test_min_int(GL_MAX_SERVER_WAIT_TIMEOUT, 0);
> +       piglit_test_min_int64(GL_MAX_SERVER_WAIT_TIMEOUT, 0);
>  
>         piglit_test_min_int(GL_MAX_DRAW_BUFFERS, 8);
>         piglit_test_min_int(GL_SAMPLE_BUFFERS, 0);
> diff --git a/tests/spec/gl-3.3/minmax.c b/tests/spec/gl-3.3/minmax.c
> index 2eae411b5..7543688fa 100644
> --- a/tests/spec/gl-3.3/minmax.c
> +++ b/tests/spec/gl-3.3/minmax.c
> @@ -141,7 +141,7 @@ piglit_init(int argc, char **argv)
>         piglit_test_min_int(GL_MAX_COLOR_TEXTURE_SAMPLES, 1);
>         piglit_test_min_int(GL_MAX_DEPTH_TEXTURE_SAMPLES, 1);
>         piglit_test_min_int(GL_MAX_INTEGER_SAMPLES, 1);
> -       piglit_test_min_int(GL_MAX_SERVER_WAIT_TIMEOUT, 0);
> +       piglit_test_min_int64(GL_MAX_SERVER_WAIT_TIMEOUT, 0);
>  
>         piglit_test_min_int(GL_MAX_DRAW_BUFFERS, 8);
>         piglit_test_min_int(GL_MAX_DUAL_SOURCE_DRAW_BUFFERS, 1);
> -- 
> 2.11.0.windows.1
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170906/7910fef9/attachment.sig>