[Piglit] [PATCH 1/4] utils/glx: Don't create X pixmaps unsupported by x-screen. (v2)

Michel Dänzer michel at daenzer.net
Thu Sep 7 07:07:34 UTC 2017


On 07/09/17 11:43 AM, Mario Kleiner wrote:
> XCreatePixmap doesn't like that. Fixes piglit regression if the
> GL implementation exposes RGB10 depth 30 FBConfigs, but the X-Screen
> is set to default DefaultDepth of 24 bits, and therefore does not
> support depth 30 pixmaps.
> 
> On RGB10 enabled Mesa fixes these tests on depth 24 screen:
> 
> glx-visuals-depth -pixmap
> glx-visuals-stencil -pixmap
> 
> v2: Switch from checking against DefaultDepth of root window
>     to checking against XListDepths() list of supported depths,
>     as suggested by Michel.
> 
> Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com>

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the Piglit mailing list