[Piglit] [PATCH] tests: intel_blackhole_render: use GLSL ES 1.0 on ES profiles
Tapani Pälli
tapani.palli at intel.com
Mon Apr 9 15:16:37 UTC 2018
One nit that you can consider below ..
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
On 09.04.2018 14:00, Lionel Landwerlin wrote:
> Not all of our platforms support GLSL ES 3.0 so extend the coverage by
> lowering the GLSL requirements.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
> tests/spec/intel_blackhole_render/blackhole_draw.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tests/spec/intel_blackhole_render/blackhole_draw.c b/tests/spec/intel_blackhole_render/blackhole_draw.c
> index 32249c8a7..cbabffc0c 100644
> --- a/tests/spec/intel_blackhole_render/blackhole_draw.c
> +++ b/tests/spec/intel_blackhole_render/blackhole_draw.c
> @@ -54,10 +54,11 @@ piglit_display(void)
> prog = piglit_build_simple_program(
> #if defined(PIGLIT_USE_OPENGL)
> "#version 330\n"
> + "in vec4 piglit_vertex;\n"
> #elif defined(PIGLIT_USE_OPENGL_ES2) || defined(PIGLIT_USE_OPENGL_ES3)
> - "#version 300 es\n"
> + "#version 100\n"
> + "attribute vec4 piglit_vertex;\n"
> #endif
> - "in vec4 piglit_vertex;\n"
> "void main()\n"
> "{\n"
> " gl_Position = piglit_vertex;\n"
> @@ -66,8 +67,8 @@ piglit_display(void)
> "#version 330\n"
> "out vec4 color;\n"
> #elif defined(PIGLIT_USE_OPENGL_ES2) || defined(PIGLIT_USE_OPENGL_ES3)
> - "#version 300 es\n"
> - "out highp vec4 color;\n"
> + "#version 100\n"
> + "#define color gl_FragColor\n"
Maybe just use gl_FragColor below?
> #endif
> "void main()\n"
> "{\n"
>
More information about the Piglit
mailing list