[Piglit] [PATCH 00/35] Serialize profiles into XML at build time

Marek Olšák maraeo at gmail.com
Wed Apr 11 19:40:07 UTC 2018


On Tue, Apr 10, 2018 at 9:54 PM, Mark Janes <mark.a.janes at intel.com> wrote:

> Dylan Baker <dylan at pnwbakers.com> writes:
>
> > Quoting Marek Olšák (2018-04-10 14:22:10)
> >> On Tue, Apr 10, 2018 at 2:15 PM, Dylan Baker <dylan at pnwbakers.com>
> wrote:
> >>
> >>     Quoting Eric Anholt (2018-04-09 17:10:35)
> >>     > Marek Olšák <maraeo at gmail.com> writes:
> >>     >
> >>     > > Is this use case affected?
> >>     > >
> >>     > > piglit run --deqp-mustpass-list --process-isolation 0 -p gbm -c
> quick
> >>     > > cts_gl45 deqp_gles2 deqp_gles3 deqp_gles31
> >>     > >
> >>     > > Yes, that is just 1 command to run all those test suites at the
> same
> >>     time.
> >>     > >
> >>     > > I use my personal "deqp" piglit branch that also disables
> process
> >>     isolation
> >>     > > for glcts and deqp, and parses the deqp mustpass lists which
> are in txt
> >>     > > files.
> >>     >
> >>     > Parsing the mustpass lists sounds really useful.  Trying to
> construct an
> >>     > appropriate command line otherwise has been quite a challenge.
> >>
> >>     That option is already in core piglit, you just need to configure
> your
> >>     piglit.conf appropriately. I guess we really should have that in the
> >>     piglit.conf.example file...
> >>
> >>
> >> I doubt it. Why would I have these then:
> >>
> >> https://cgit.freedesktop.org/~mareko/piglit/commit/?h=deqp&id=
> >> 0b11344e0c18b9bf07ad12381b94f308f362eb88
> >> https://cgit.freedesktop.org/~mareko/piglit/commit/?h=deqp&id=
> >> b086d8f82d41338055ab48bdda78c4a0c1ee02d0
> >> https://cgit.freedesktop.org/~mareko/piglit/commit/?h=deqp&id=
> >> 90beefa825cda792eaa72bff2cefac463af6d08a
> >>
> >> Marek
> >
> > Because in late 2016 (there is some internal stuff that happened so we
> stopped
> > using piglit to run deqp I'm not entirely happy about) they changed the
> mustpass
> > list from xml to txt and no one ever updated it in master.
>
> I'm not sure what you are referring to here.  We stopped using piglit
> for dEQP because the run-time was 10X faster with a custom runner.  We
> don't have process isolation anymore, but we recover from
> crashes/assertions without paying the penalty of iterating the dEQP test
> list for each test run.
>
> Google dEQP authors recommended this path.
>

My deqp piglit branch might be just as fast or nearly as fast as your
custom runner if process isolation is explicitly disabled.

Marek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180411/c32be6b5/attachment.html>


More information about the Piglit mailing list