[Piglit] [PATCH] add tests for using immediates in common operations

Eric Anholt eric at anholt.net
Mon Apr 23 20:49:46 UTC 2018


Ilia Mirkin <imirkin at alum.mit.edu> writes:

> NVIDIA hardware has "short" immediates, and some instructions have both
> long and short immediate variants. Nouveau was picking the wrong one
> under certain conditions. This adds tests which are likely to cause
> these kinds of issues to surface in a backend.

My only concern is the integer multiply tests on non-native-integer
hardware or things where the number of integer bits is too small.  That
said, whoever tries to support one of those will have plenty of problems
already and need to define some shader_runner precision requirement
annotations.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180423/e8fce80b/attachment.sig>


More information about the Piglit mailing list