[Piglit] [PATCH] cl: Fix types to be unsigned

Jan Vesely jan.vesely at rutgers.edu
Mon Aug 13 21:52:12 UTC 2018


On Mon, 2018-08-13 at 23:42 +0300, Matt Arsenault wrote:
> ping

Reviewed-by: Jan Vesely <jan.vesely at rutgers.edu>

> 
> > On Oct 27, 2017, at 13:03, Matt Arsenault <arsenm2 at gmail.com> wrote:
> > 
> > Doesn't really matter.

so why change it?
still passes on clover carrizo/iceland

Jan

> > ---
> > tests/cl/program/execute/store-hi16.cl | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/tests/cl/program/execute/store-hi16.cl b/tests/cl/program/execute/store-hi16.cl
> > index b734b3766..4273d3369 100644
> > --- a/tests/cl/program/execute/store-hi16.cl
> > +++ b/tests/cl/program/execute/store-hi16.cl
> > @@ -92,7 +92,7 @@ kernel void store_hi16_global(volatile global ushort* out, volatile global uint*
> > 
> > kernel void store_hi16_local(volatile global ushort* out, volatile global uint* in)
> > {
> > -    volatile local short lds[64];
> > +    volatile local ushort lds[64];
> >     int lid = get_local_id(0);
> >     int gid = get_global_id(0);
> > 
> > @@ -104,7 +104,7 @@ kernel void store_hi16_local(volatile global ushort* out, volatile global uint*
> > kernel void store_hi16_private(volatile global ushort* out, volatile global uint* in)
> > {
> >     int gid = get_global_id(0);
> > -    volatile private short stack = in[gid] >> 16;
> > +    volatile private ushort stack = in[gid] >> 16;
> >     out[gid] = stack;
> > }
> > 
> > @@ -117,7 +117,7 @@ kernel void truncstorei8_hi16_global(volatile global uchar* out, volatile global
> > 
> > kernel void truncstorei8_hi16_local(volatile global uchar* out, volatile global uint* in)
> > {
> > -    volatile local short lds[64];
> > +    volatile local ushort lds[64];
> >     int lid = get_local_id(0);
> >     int gid = get_global_id(0);
> > 
> > @@ -129,6 +129,6 @@ kernel void truncstorei8_hi16_local(volatile global uchar* out, volatile global
> > kernel void truncstorei8_hi16_private(volatile global uchar* out, volatile global uint* in)
> > {
> >     int gid = get_global_id(0);
> > -    volatile private short stack = in[gid] >> 16;
> > +    volatile private ushort stack = in[gid] >> 16;
> >     out[gid] = (uchar)stack;
> > }
> > -- 
> > 2.11.0
> > 
> 
> 

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180813/39d6eb8f/attachment.sig>


More information about the Piglit mailing list