[Piglit] [PATCH] arb_texture_buffer_object/indexed: test indexed samplers with tbo

Roland Scheidegger sroland at vmware.com
Wed Jan 3 03:48:14 UTC 2018


Am 03.01.2018 um 04:40 schrieb Ilia Mirkin:
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
> 
> On Tue, Jan 2, 2018 at 9:27 PM,  <sroland at vmware.com> wrote:
>> +       static const char *fs_source =
>> +               "#version 150\n"
>> +               "#extension GL_ARB_gpu_shader5: require\n"
>> +               "uniform samplerBuffer s[2];\n"
>> +               "uniform int offset;\n"
>> +               "uniform int index;\n"
> 
> A little trick I like to use in piglits is "uniform int index = 1\n".
> That way it's still a uniform, but I don't have to bother setting it.
> Your call.
> 

Yes, albeit for some reason it's not done that way in most piglits.
Not sure why really, certainly looks like it would make sense for
uniforms which are not meant to be changed.

Roland


More information about the Piglit mailing list