[Piglit] [PATCH] ubo/execution: test {row, column}_major mat4 access

Ilia Mirkin imirkin at alum.mit.edu
Wed Jan 10 13:18:08 UTC 2018


On Wed, Jan 10, 2018 at 7:20 AM, Florian Will <florian.will at gmail.com> wrote:
>> Existing tests apparently never attempt to read data from row_major
>> matrices in their UBOs. This catches Mesa bug 104553.
>
> uses the m[i][j] syntax (same for vectors). I have modified the script
> a bit to generate [j] checks in addition to .{x,y,z,w} checks. If that
> seems like a good idea I can send the (quite obvious) patch, but I

Yes, please!

> think that feature is only supported in OpenGL 3.x+ and the tests
> currently support 1.3, so maybe it's better to keep it that way.

GLSL 1.30 == GL 3.0.

  -ilia


More information about the Piglit mailing list