[Piglit] [PATCH 1/3] gl-1.0-blend-func: don't pass counter var to proc_factors()

[Fabian Bieler]

This does break the commented out debug printf in proc_factors on line 668. Maybe adjust remove remove counter from there, as well?

Reviewed-by: Fabian Bieler <fabianbieler at fastmail.fm>

On Wed, Jan 17, 2018, at 11:54 PM, Brian Paul wrote:
> Just increment the test counter in run_all_factor_sets().
> ---
>  tests/spec/gl-1.0/blend.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/spec/gl-1.0/blend.c b/tests/spec/gl-1.0/blend.c
> index c1796a5..769339f 100644
> --- a/tests/spec/gl-1.0/blend.c
> +++ b/tests/spec/gl-1.0/blend.c
> @@ -635,8 +635,7 @@ run_factor_set(GLenum src_factor_rgb, GLenum src_factor_a,
>  } /* run_factor_set */
>  
>  bool
> -proc_factors(int sf, int sfa, int df, int dfa, int* counter, 
> -	int op, int opa)
> +proc_factors(int sf, int sfa, int df, int dfa, int op, int opa)
>  {
>  	GLenum src_rgb, src_a, dst_rgb, dst_a;
>  
> @@ -659,9 +658,6 @@ proc_factors(int sf, int sfa, int df, int dfa, int* counter,
>  			needs_blend_color(dst_a)))
>  		return true;
>  
> -	/* Increment counter so that tests are numbered starting from 1. */
> -	(*counter)++; 
> -
>  	/* For verification purposes, this prints every test
>  	 * configuration as it runs.*/
>  	/*
> @@ -791,8 +787,8 @@ run_all_factor_sets(void)
>  							pass &= proc_factors(
>  								sf, sfa, 
>  								df, dfa,
> -								&counter,
>  								op, opa);
> +							counter++;
>  						}
>  					}
>  				}
> -- 
> 2.7.4
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit