[Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

Eric Anholt eric at anholt.net
Fri Jan 19 05:35:17 UTC 2018


Brian Paul <brianp at vmware.com> writes:

> On 01/18/2018 01:27 PM, Eric Anholt wrote:
>> Brian Paul <brianp at vmware.com> writes:
>> 
>>> To avoid an infinite loop.  See code comments for details.
>> 
>> Skipping a failing test and returning pass is wrong to me.
>
> It's not ideal.  But the bug is in LLVM and cannot readily be fixed in 
> llvmpipe.
>
> I could have the test return a WARN result in this situation.  Would 
> that be better?

It's still a bug in the driver, even if it's because the driver's using
a buggy external library.  It should be a fail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180118/1069ce15/attachment.sig>


More information about the Piglit mailing list