[Piglit] [PATCH] arb_blend_func_extended: Test dual src blending without second color output
Dylan Baker
dylan at pnwbakers.com
Fri Jul 6 17:11:54 UTC 2018
Quoting Danylo Piliaiev (2018-07-06 07:17:59)
> Thank you for the feedback, I'll send fixed version soon.
>
>
> On 06.07.18 16:48, Ilia Mirkin wrote:
> > On Fri, Jul 6, 2018 at 4:51 AM, Danylo Piliaiev
> > <danylo.piliaiev at gmail.com> wrote:
> >> Using fragment shader without second color output should not hang gpu
> >> when dual source blending is enabled.
> >> It hanged Intel gen8+ GPUs when discarding fragments and depth test
> >> being enabled.
> >> There is also safeguard against lack of second color output in radeonsi.
> >>
> >> Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
> >> ---
> >> To not hang hang on Intel gen8+ GPUs this patch depends on
> >> https://patchwork.freedesktop.org/patch/235939/
> >> The hang itself is around 2 - 5 seconds and test produces FAIL.
> >>
> >> tests/opengl.py | 2 +
> >> .../execution/CMakeLists.gl.txt | 1 +
> >> .../execution/CMakeLists.gles3.txt | 1 +
> >> .../dual-src-blending-discard-without-src1.c | 120 ++++++++++++++++++
> >> 4 files changed, 124 insertions(+)
> >> create mode 100644 tests/spec/arb_blend_func_extended/execution/dual-src-blending-discard-without-src1.c
> >>
> >> diff --git a/tests/opengl.py b/tests/opengl.py
> >> index 02110ff86..61aa197b7 100644
> >> --- a/tests/opengl.py
> >> +++ b/tests/opengl.py
> >> @@ -4114,6 +4114,7 @@ with profile.test_list.group_manager(
> >> g(['arb_blend_func_extended-fbo-extended-blend'])
> >> g(['arb_blend_func_extended-fbo-extended-blend-explicit'])
> >> g(['arb_blend_func_extended-fbo-extended-blend-pattern'])
> >> + g(['arb_blend_func_extended-dual-src-blending-discard-without-src1'], run_concurrent=False)
> > Why run_concurrent=False?
> I set it because this test may hang which can affect other tests but if
> it won't an issue I can remove it.
Please remove it, we disable concurrency for tests which will actively interfere
with other tests such as tests for frontbuffer rendering or tests like
arb_timer_query which are sensitive to busy systems only.
Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180706/5ff5046f/attachment.sig>
More information about the Piglit
mailing list