[Piglit] [PATCH] glx-oml-sync-control-timing: Make test behavior more stable

[Mario Kleiner]

On Mon, Jul 9, 2018 at 9:09 PM, Illia Iorin <illia.iorin at gmail.com> wrote:
> The fourfold increase in the test failure condition
> is due to its unstable work. The old condition was left,
> but the test result was changed from fail to warn, added
> fail condition.
>

Hi, can you clarify what the commit message wrt. "fourfold increase...
due to its unstable work" means? I'd like to understand the observed
issue better.

thanks,
-mario

> Cc: Michel Dänzer <michel.daenzer at amd.com>
> Cc: Emil Velikov <emil.velikov at collabora.com>
> Signed-off-by: Illia Iorin <illia.iorin at globallogic.com>
> ---
>  tests/spec/glx_oml_sync_control/timing.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/spec/glx_oml_sync_control/timing.c b/tests/spec/glx_oml_sync_control/timing.c
> index ab7258940..6d810af52 100644
> --- a/tests/spec/glx_oml_sync_control/timing.c
> +++ b/tests/spec/glx_oml_sync_control/timing.c
> @@ -332,7 +332,10 @@ draw(Display *dpy)
>                                 " does not match glXGetMscRateOML %fus\n",
>                                 msc_wallclock_duration_stats.mean,
>                                 expected_msc_wallclock_duration);
> -                       result = PIGLIT_FAIL;
> +                       piglit_merge_result(&result, PIGLIT_WARN);
> +                       if (fabs(expected_msc_wallclock_duration -
> +                                msc_wallclock_duration_stats.mean) > 200)
> +                               result = PIGLIT_FAIL;
>                 }
>         }
>
> --
> 2.17.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit