[Piglit] [PATCH 0/3] glx-oml-sync-control-timing fixes

[Michel Dänzer]

On 2018-06-07 01:02 PM, Emil Velikov wrote:
> On 7 June 2018 at 10:58, Michel Dänzer <michel at daenzer.net> wrote:
>> On 2017-04-14 09:06 AM, Michel Dänzer wrote:
>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>
>>> Patch 1 fixes an error message typo I noticed along the way.
>>>
>>> Patches 2 & 3 allow the glx-oml-sync-control-timing tests to
>>> consistently pass for me, at least if the system isn't otherwise
>>> loaded. Before, they would randomly generate warnings even in that
>>> case.
>>>
>>> Michel Dänzer (3):
>>>   glx-oml-sync-control-timing: Fix error message if glXWaitForMscOML
>>>     fails
>>>   glx-oml-sync-control-timing: Refactor helper functions for swap / wait
>>>   glx-oml-sync-control-timing: Perform warm-up swap / wait before loop
>>
>> Any feedback on these?
>>
>> https://patchwork.freedesktop.org/series/23063/
>>
>> They still apply and work as well as they did last year.
>>
>>
>> Without negative feedback, I'm planning to push these soon.
>>
> To provide some clarity (in 3/3), might be worth coping the commit
> message as inline comment.

Right, that occurred to me as well. I converted the gist of the commit
log to a comment before pushing.


> Regardless, the series is
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks!


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer