[Piglit] [PATCH v1] cmake: Use Policy CMP0072 as OLD by default.

Dylan Baker dylan at pnwbakers.com
Tue Jun 12 15:49:18 UTC 2018


Quoting Sergii Romantsov (2018-06-12 05:57:45)
> Hello.
> 
>     Seems reasonable,
>     Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
> 
> 
> Could we push it?
> 
> On Fri, Jun 8, 2018 at 6:51 PM, Dylan Baker <dylan at pnwbakers.com> wrote:
> 
>     Quoting Sergii Romantsov (2018-06-08 02:19:01)
>     > If system has installed both GL libraries such as
>     > Legacy and GLVND, cmake will dump warning:
>     >
>     > "OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY",
>     > so for compatibility with CMake 3.10 and below the legacy GL
>     > library will be used."
>     >
>     > Added usage of Policy CMP0072 as OLD (that selects LEGACY-library
>     > libGL.so by default).
>     >
>     > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106857
>     > Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
>     > ---
>     >  CMakeLists.txt | 4 ++++
>     >  1 file changed, 4 insertions(+)
>     >
>     > diff --git a/CMakeLists.txt b/CMakeLists.txt
>     > index e56aafb..02bdc56 100644
>     > --- a/CMakeLists.txt
>     > +++ b/CMakeLists.txt
>     > @@ -15,6 +15,10 @@ if (POLICY CMP0042)
>     >         cmake_policy (SET CMP0042 NEW)
>     >  endif()
>>     > +if (POLICY CMP0072)
>     > +        cmake_policy (SET CMP0072 OLD)
>     > +endif()
>     > +
>     >  project (piglit)
>>     >  # Require MinGW
>     > --
>     > 2.7.4
>     >
>     > _______________________________________________
>     > Piglit mailing list
>     > Piglit at lists.freedesktop.org
>     > https://lists.freedesktop.org/mailman/listinfo/piglit
> 
>     Seems reasonable,
>     Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
> 
> 

Pushed. Thanks for following up, I didn't realize you didn't have commit access.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180612/034e52b3/attachment.sig>


More information about the Piglit mailing list