[Piglit] [PATCH] tests: add nvidia conservative rasterization tests

Pending Chaos pendingchaos02 at gmail.com
Sat Mar 31 10:13:58 UTC 2018


GL_NV_conservative_raster, GL_NV_conservative_raster_dilate and
GL_NV_conservative_raster_pre_snap_triangles are three separate extensions.

On Sat, Mar 31, 2018 at 1:01 AM, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Rhys Perry (2018-03-22 06:43:25)
>> Adds tests for GL_NV_conservative_raster, GL_NV_conservative_raster_dilate
>> and GL_NV_conservative_raster_pre_snap_triangles.
>> ---
>>  tests/all.py                                       |  20 ++
>>  tests/spec/CMakeLists.txt                          |   3 +
>>  .../spec/nv_conservative_raster/CMakeLists.gl.txt  |  13 +
>>  .../nv_conservative_raster/CMakeLists.gles2.txt    |   3 +
>>  tests/spec/nv_conservative_raster/CMakeLists.txt   |   1 +
>>  tests/spec/nv_conservative_raster/attrib.c         |  69 +++++
>>  tests/spec/nv_conservative_raster/dlist.c          |  75 ++++++
>>  tests/spec/nv_conservative_raster/draw.c           | 288 +++++++++++++++++++++
>>  .../CMakeLists.gl.txt                              |  11 +
>>  .../CMakeLists.gles2.txt                           |   3 +
>>  .../nv_conservative_raster_dilate/CMakeLists.txt   |   1 +
>>  tests/spec/nv_conservative_raster_dilate/draw.c    | 128 +++++++++
>>  .../CMakeLists.gl.txt                              |  11 +
>>  .../CMakeLists.gles2.txt                           |   3 +
>>  .../CMakeLists.txt                                 |   1 +
>>  .../draw.c                                         | 117 +++++++++
>>  16 files changed, 747 insertions(+)
>>  create mode 100644 tests/spec/nv_conservative_raster/CMakeLists.gl.txt
>>  create mode 100644 tests/spec/nv_conservative_raster/CMakeLists.gles2.txt
>>  create mode 100644 tests/spec/nv_conservative_raster/CMakeLists.txt
>>  create mode 100644 tests/spec/nv_conservative_raster/attrib.c
>>  create mode 100644 tests/spec/nv_conservative_raster/dlist.c
>>  create mode 100644 tests/spec/nv_conservative_raster/draw.c
>>  create mode 100644 tests/spec/nv_conservative_raster_dilate/CMakeLists.gl.txt
>>  create mode 100644 tests/spec/nv_conservative_raster_dilate/CMakeLists.gles2.txt
>>  create mode 100644 tests/spec/nv_conservative_raster_dilate/CMakeLists.txt
>>  create mode 100644 tests/spec/nv_conservative_raster_dilate/draw.c
>>  create mode 100644 tests/spec/nv_conservative_raster_pre_snap_triangles/CMakeLists.gl.txt
>>  create mode 100644 tests/spec/nv_conservative_raster_pre_snap_triangles/CMakeLists.gles2.txt
>>  create mode 100644 tests/spec/nv_conservative_raster_pre_snap_triangles/CMakeLists.txt
>>  create mode 100644 tests/spec/nv_conservative_raster_pre_snap_triangles/draw.c
>>
>> diff --git a/tests/all.py b/tests/all.py
>> index 4cd911fab..a5da80f14 100644
>> --- a/tests/all.py
>> +++ b/tests/all.py
>> @@ -4984,5 +4984,25 @@ with profile.test_list.group_manager(
>>      g(['arb_bindless_texture-uint64_attribs'], 'uint64_attribs')
>>      g(['arb_bindless_texture-uniform'], 'uniform')
>>
>> +# Group NV_conservative_raster
>> +with profile.test_list.group_manager(
>> +       PiglitGLTest,
>> +       grouptools.join('spec', 'NV_conservative_raster')) as g:
>> +    g(['nv_conservative_raster-draw'], 'draw')
>> +    g(['nv_conservative_raster-dlist'], 'dlist')
>> +    g(['nv_conservative_raster-attrib'], 'attrib')
>> +
>> +# Group NV_conservative_raster_dilate
>> +with profile.test_list.group_manager(
>> +       PiglitGLTest,
>> +       grouptools.join('spec', 'NV_conservative_raster_dilate')) as g:
>> +    g(['nv_conservative_raster_dilate-draw'], 'draw')
>> +
>> +# Group NV_conservative_raster_pre_snap_triangles
>> +with profile.test_list.group_manager(
>> +       PiglitGLTest,
>> +       grouptools.join('spec', 'NV_conservative_raster_pre_snap_triangles')) as g:
>> +    g(['nv_conservative_raster_pre_snap_triangles-draw'], 'draw')
>
> I'm asking because I don't know the answer, but are these three separate
> extensions? Usually we don't create separate groups for the same extension. We
> might have sub-groups like `spec, arb_ham_sandwhich, gluten_free`.
>
> Dylan


More information about the Piglit mailing list