[Piglit] [PATCH 1/7] gl-1.0-blend: Fix problems with blend extension detection

[Ian Romanick]

On 05/02/2018 10:47 AM, Eric Anholt wrote:
> Ian Romanick <idr at freedesktop.org> writes:
> 
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> There were two bugs here.  First, GL_EXT_blend_color and
>> GL_EXT_blend_func_separate were only tested if the version is 1.4.  This
>> is unnecessary because those extensions are part of OpenGL 1.4.  Second,
>> GL_EXT_blend_minmax was typoed GL_EXT_blend_min_max.
> 
> Looks like GL_EXT_blend_color at least is only in 1.4 if the imaging
> subset is supported, which it looks like we don't do in Mesa.  So I

We definitely do not support the imaging subset.  My understanding is
that GL_EXT_blend_color was part of the imaging subset in 1.2 and 1.3,
but it was pulled into core in 1.4.  I got that from appendix G.3
(Changes to the Imaging Subset), which says:

    The subset of blending features described by BlendEquation,
    BlendColor, and the BlendFunc modes CONSTANT_COLOR,
    ONE_MINUS_CONSTANT_COLOR, CONSTANT_ALPHA, and
    ONE_MINUS_CONSTANT_ALPHA are now supported. These feature were
    available only in the optional imaging subset in versions 1.2 and
    1.3 of the GL.

Mesa's compute_version also requires EXT_blend_color for 1.4.

> think we should disentangle these two changes, and r-b from me on the
> typo fix.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180503/bccf72ff/attachment.sig>