[Piglit] [PATCH v2] glsl-1.30: add tests for using immediates in common operations
imirkin at alum.mit.edu
Thu May 3 21:59:07 UTC 2018
On Thu, May 3, 2018 at 5:58 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 04/27/2018 04:56 PM, Ilia Mirkin wrote:
>> On Fri, Apr 27, 2018 at 9:07 AM, Ian Romanick <idr at freedesktop.org> wrote:
>>> On 04/27/2018 12:01 AM, Ilia Mirkin wrote:
>>>> NVIDIA hardware has "short" immediates, and some instructions have both
>>>> long and short immediate variants. Nouveau was picking the wrong one
>>>> under certain conditions. This adds tests which are likely to cause
>>>> these kinds of issues to surface in a backend.
>>> It might be worth putting a note about this in the test scripts.
>>> Otherwise, someone may come along later, and, thinking the tests are
>>> redundant, try to remove them.
>> Wouldn't that someone ideally check why the tests were added, pointing
>> them at this commit?
>> Are you suggesting I reproduce the above quoted section at the top of
>> each test as a comment?
> It's just a suggestion. ;)
But is that what you're suggesting? You just said "a note", so I
wasn't sure what sort of thing you wanted. I can drop whatever text
in, it's fine...
More information about the Piglit