[Piglit] [PATCH 00/35] Serialize profiles into XML at build time

Juan A. Suarez Romero jasuarez at igalia.com
Fri May 4 11:50:27 UTC 2018


On Fri, 2018-05-04 at 12:03 +0200, Juan A. Suarez Romero wrote:
> On Wed, 2018-05-02 at 13:57 -0700, Dylan Baker wrote:
> > Quoting Juan A. Suarez Romero (2018-05-02 09:49:08)
> > > Hi, Dylan.
> > > 
> > > I see you've pushed this series.
> > > 
> > > Now, when I'm trying to run some profiles (mainly, tests/crucible and
> > > tests/khr_gl* ), seems they are broken:
> > > 
> > > [0000/7776]
> > > Traceback (most recent call last):
> > >   File "./piglit", line 178, in <module>
> > >     main()
> > >   File "./piglit", line 174, in main
> > >     sys.exit(runner(args))
> > >   File "/home/igalia/jasuarez/piglit/framework/exceptions.py", line 51, in
> > > _inner
> > >     func(*args, **kwargs)
> > >   File "/home/igalia/jasuarez/piglit/framework/programs/run.py", line 370, in
> > > run
> > >     backend.finalize({'time_elapsed': time_elapsed.to_json()})
> > >   File "/home/igalia/jasuarez/piglit/framework/backends/json.py", line 163, in
> > > finalize
> > >     assert data['tests']
> > > AssertionError
> > > 
> > >         J.A.
> > > 
> > 
> > Dang.
> > 
> > I can't reproduce any failures with crucible, though I did make it thread safe
> > and fix the using a config file :)
> > 
> > I can't get the glcts binary to run, no matter what target I build for I run
> > into either EGL errors of GL errors.
> > 
> 
> More info on this issue.
> 
> It seems it happens with the profiles that requires to use an external runner
> (crucible, vk-gl-cts, deqp, ...).
> 
> 
> When executing, it tells it will run all the tests, but sometimes it just
> execute one test, other times 2, and other times none. It is in the last case
> when the error above is shown.
> 
> Still don't know why.
> 


Found the problem in this commit:

commit 9461d92301e72807eba4776a16a05207e3a16477
Author: Dylan Baker <dylan at pnwbakers.com>
Date:   Mon Mar 26 15:23:17 2018 -0700

    framework/profile: Add a __len__ method to TestProfile
    
    This exposes a standard interface for getting the number of tests in a
    profile, which is itself nice. It will also allow us to encapsulate the
    differences between the various profiles added in this series.
    
    Tested-by: Rafael Antognolli <rafael.antognolli at intel.com>


> 	J.A.
> 
> > Dylan
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list