[Piglit] [PATCH 00/35] Serialize profiles into XML at build time

[Michel Dänzer]

On 2018-05-08 07:19 PM, Dylan Baker wrote:
> Quoting Michel Dänzer (2018-05-08 07:07:34)
>>
>> I just bisected another problem to
>> 9461d92301e72807eba4776a16a05207e3a16477: The xts-render profile doesn't
>> work anymore. Most of the time, it doesn't even start:
>>
>> [000/480]  
>> Traceback (most recent call last):
>>   File "./piglit", line 178, in <module>
>>     main()
>>   File "./piglit", line 174, in main
>>     sys.exit(runner(args))
>>   File "/home/daenzer/src/piglit-git/piglit/framework/exceptions.py", line 51, in _inner
>>     func(*args, **kwargs)
>>   File "/home/daenzer/src/piglit-git/piglit/framework/programs/run.py", line 370, in run
>>     backend.finalize({'time_elapsed': time_elapsed.to_json()})
>>   File "/home/daenzer/src/piglit-git/piglit/framework/backends/json.py", line 163, in finalize
>>     assert data['tests']
>> AssertionError
>>
>> Sometimes, it doesn't fail like this, but only runs between 0 and another
>> number < 480 of tests. Very rarely, it manages to run all tests.
>>
>> (I'm using python 3.6 now)
>>
>>
>> Dylan, since a number of issues have been reported to have started with
>> this commit, and you don't seem to have an idea what's wrong with it,
>> can you revert it and anything depending on it for the time being? I'll
>> be happy to test against the issues I've run into when you're ready to
>> try again.
> 
> That would mean reverting nearly 20 commits

I appreciate that would suck, but so does having piglit in a regressed
state for a week, with slow progress towards fixing all the regressions.

> and giving up considerable runtime reductions for us

The thing is, while I can see that the time until running the first test
has been greatly reduced,

 ./piglit run -x basic-arithmetic-uvec2-texture2d -x
glx-multithread-texture --process-isolation false gpu

takes significantly longer to finish now (~8 minutes) than before
9461d92301e72807eba4776a16a05207e3a16477 (~4.5 minutes), with radeonsi
on an 8-core Ryzen CPU.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 224 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180509/090dcf0a/attachment-0001.sig>