[Piglit] [PATCH 1/4] framework: ensure that all tests are run before exiting

Dylan Baker dylan at pnwbakers.com
Wed May 9 17:38:32 UTC 2018


Quoting Michel Dänzer (2018-05-09 02:33:13)
> On 2018-05-08 11:27 PM, Dylan Baker wrote:
> > Michel, does this series fix the remaining issues you're seeing?
> 
> It mostly fixes the gpu profile running fewer tests than before. The
> only remaining minor issue there is that the
> shaders at glsl-{fs,vs}-{inline,unroll}-explosion tests were previously
> accurately listed as "crash" in the summary, now it's "notrun".

That's odd, the filtering of tests that have '-explosion' in the name has been
in quick.py for a *long* time, since they can take a long time to run, and gpu
is quick.py without glslparser tests.

> 
> Tested-by: Michel Dänzer <michel.daenzer at amd.com>
> 
> 
> The bigger remaining issue is that --process-isolation false gpu takes
> almost twice as long as it did before
> 9461d92301e72807eba4776a16a05207e3a16477.

Is it running significantly more tests? When I run the two profiles I see 2
different tests, and that master takes ~1 minute longer to run. I'm thinking
about how I could reduce the runtime without hurting startup time or exploding
the memory usage.

I'll make the process-isolation flag work again too.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180509/405c1742/attachment.sig>


More information about the Piglit mailing list