[Piglit] [PATCH] cmake: Bump minimum version to 3.2.

Dylan Baker dylan at pnwbakers.com
Mon May 21 22:14:16 UTC 2018


Quoting Vinson Lee (2018-05-17 13:28:26)
> This build error occurs with cmake 2.8.12.
> /bin/sh: BYPRODUCTS: command not found
> 
> BYPRODUCTS is not available until cmake 3.2.
> https://cmake.org/cmake/help/v3.2/release/3.2.html
> 
> Fixes: 2f02cf0d4c2d ("Generate xml for builtin profiles")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106370
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
>  CMakeLists.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 8c7d162..e56aafb 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -1,4 +1,4 @@
> -cmake_minimum_required(VERSION 2.8.5)
> +cmake_minimum_required(VERSION 3.2)
>  
>  list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/Modules")
>  
> -- 
> 1.7.1
> 

I could have sworn I replied to this already, sorry about that.

This seems reasonable to me, and I was going to propose it myself. 3.2 is from
2015, and 3.11 is current, and requiring software that's ~3 years old seems fine
for a test suite.

Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180521/df14ca52/attachment.sig>


More information about the Piglit mailing list