[Piglit] [PATCH] gl-3.2-compat: Fix GCC format-security warnings.

Vinson Lee vlee at freedesktop.org
Thu May 31 21:31:10 UTC 2018


glsl-fs-fogscale.c: In function ‘piglit_display’:
glsl-fs-fogscale.c:140:3: warning: format not a string literal and no format arguments [-Wformat-security]
   piglit_report_subtest_result(PIGLIT_SKIP, tests[1]);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
glsl-fs-fogscale.c:141:3: warning: format not a string literal and no format arguments [-Wformat-security]
   piglit_report_subtest_result(PIGLIT_SKIP, tests[2]);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: e28f602973f6 ("gl-3.2-compat: test gl_FogFragCoord built-in with geometry shaders")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
---
 tests/shaders/glsl-fs-fogscale.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/shaders/glsl-fs-fogscale.c b/tests/shaders/glsl-fs-fogscale.c
index 8945371bfc0b..ff682dc48150 100644
--- a/tests/shaders/glsl-fs-fogscale.c
+++ b/tests/shaders/glsl-fs-fogscale.c
@@ -137,8 +137,8 @@ piglit_display(void)
 		pass = pass && test_prog(prog, tests[2]);
 
 	} else {
-		piglit_report_subtest_result(PIGLIT_SKIP, tests[1]);
-		piglit_report_subtest_result(PIGLIT_SKIP, tests[2]);
+		piglit_report_subtest_result(PIGLIT_SKIP, "%s", tests[1]);
+		piglit_report_subtest_result(PIGLIT_SKIP, "%s", tests[2]);
 	}
 
 	return pass ? PIGLIT_PASS : PIGLIT_FAIL;
-- 
2.14.1



More information about the Piglit mailing list