[Piglit] [PATCH] vertex-program-two-side: Fix GCC format-security warnings.

Vinson Lee vlee at freedesktop.org
Thu May 31 21:46:43 UTC 2018


vertex-program-two-side.c: In function ‘piglit_display’:
vertex-program-two-side.c:370:3: warning: format not a string literal and no format arguments [-Wformat-security]
   piglit_report_subtest_result(PIGLIT_SKIP, tests[3]);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vertex-program-two-side.c:371:3: warning: format not a string literal and no format arguments [-Wformat-security]
   piglit_report_subtest_result(PIGLIT_SKIP, tests[4]);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vertex-program-two-side.c:372:3: warning: format not a string literal and no format arguments [-Wformat-security]
   piglit_report_subtest_result(PIGLIT_SKIP, tests[5]);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vertex-program-two-side.c:375:3: warning: format not a string literal and no format arguments [-Wformat-security]
   piglit_report_subtest_result(PIGLIT_SKIP, tests[1]);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vertex-program-two-side.c:376:3: warning: format not a string literal and no format arguments [-Wformat-security]
   piglit_report_subtest_result(PIGLIT_SKIP, tests[2]);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vertex-program-two-side.c:377:3: warning: format not a string literal and no format arguments [-Wformat-security]
   piglit_report_subtest_result(PIGLIT_SKIP, tests[3]);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vertex-program-two-side.c:378:3: warning: format not a string literal and no format arguments [-Wformat-security]
   piglit_report_subtest_result(PIGLIT_SKIP, tests[4]);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
vertex-program-two-side.c:379:3: warning: format not a string literal and no format arguments [-Wformat-security]
   piglit_report_subtest_result(PIGLIT_SKIP, tests[5]);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 09b3a817d273 ("ARB_tessellation_shader: test gl_*Color built-ins with tessellation shaders")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
---
 tests/spec/gl-2.0/vertex-program-two-side.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/spec/gl-2.0/vertex-program-two-side.c b/tests/spec/gl-2.0/vertex-program-two-side.c
index a659e521ba5a..4623c70a65cd 100644
--- a/tests/spec/gl-2.0/vertex-program-two-side.c
+++ b/tests/spec/gl-2.0/vertex-program-two-side.c
@@ -367,16 +367,16 @@ piglit_display(void)
 			free(tcs_source);
 			free(tes_source);
 		} else {
-		piglit_report_subtest_result(PIGLIT_SKIP, tests[3]);
-		piglit_report_subtest_result(PIGLIT_SKIP, tests[4]);
-		piglit_report_subtest_result(PIGLIT_SKIP, tests[5]);
+		piglit_report_subtest_result(PIGLIT_SKIP, "%s", tests[3]);
+		piglit_report_subtest_result(PIGLIT_SKIP, "%s", tests[4]);
+		piglit_report_subtest_result(PIGLIT_SKIP, "%s", tests[5]);
 		}
 	} else {
-		piglit_report_subtest_result(PIGLIT_SKIP, tests[1]);
-		piglit_report_subtest_result(PIGLIT_SKIP, tests[2]);
-		piglit_report_subtest_result(PIGLIT_SKIP, tests[3]);
-		piglit_report_subtest_result(PIGLIT_SKIP, tests[4]);
-		piglit_report_subtest_result(PIGLIT_SKIP, tests[5]);
+		piglit_report_subtest_result(PIGLIT_SKIP, "%s", tests[1]);
+		piglit_report_subtest_result(PIGLIT_SKIP, "%s", tests[2]);
+		piglit_report_subtest_result(PIGLIT_SKIP, "%s", tests[3]);
+		piglit_report_subtest_result(PIGLIT_SKIP, "%s", tests[4]);
+		piglit_report_subtest_result(PIGLIT_SKIP, "%s", tests[5]);
 	}
 
 	return pass ? PIGLIT_PASS : PIGLIT_FAIL;
-- 
2.14.1



More information about the Piglit mailing list