[Piglit] [PATCH] egl_ext_device_drm: Fix format warning.

Eric Engestrom eric.engestrom at intel.com
Thu Nov 1 16:57:43 UTC 2018


On Thursday, 2018-11-01 16:51:52 +0000, Vinson Lee wrote:
> egl_ext_device_drm.c: In function ‘main’:
> egl_ext_device_drm.c:165:52: warning: format ‘%s’ expects a matching ‘char *’ argument [-Wformat=]
>     printf("Make sure you have permissions to open %s\n");
>                                                    ~^
> 
> Fixes: 039bbe4a61d1 ("egl_ext_device_drm: don't fail the test if open("/dev/dri/cardX") errors")
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>

Yeah saw that too, thanks for typing up the fix!
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

> ---
>  tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c b/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c
> index 954ac60c8161..9fced9b35805 100644
> --- a/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c
> +++ b/tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c
> @@ -162,7 +162,8 @@ main(void)
>  		if (fd < 0) {
>  			printf("Failed to open drm device file %s: %s\n",
>  				devstring, strerror(errno));
> -			printf("Make sure you have permissions to open %s\n");
> +			printf("Make sure you have permissions to open %s\n",
> +				devstring);
>  			result = PIGLIT_WARN;
>  			eglTerminate(dpy1);
>  			continue;
> -- 
> 2.17.1
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list