[Piglit] [PATCH v2 0/2] Vulkan testing with VkRunner

[Samuel Iglesias Gonsálvez]

Hello Neil,

On Saturday, 3 November 2018 8:03:42 (CET) Neil Roberts wrote:
> Here is a second attempt at incorporating VkRunner into Piglit. This
> time, instead of copying the source code into Piglit, it now just
> executes the VkRunner executable is an external dependency. I think
> there is now more interest in maintaining VkRunner as a separate repo
> because it may later be integrated into other testing frameworks as
> well such as CTS.
> 
> If the executable is not found then Piglit will automatically report
> the test as skipped. It will normally be searched for in the PATH, but
> its location can be overridden with the PIGLIT_VKRUNNER_BINARY
> environment variable.
> 

Thanks for submitting this patch series. I really like it :-)

Just a couple of comments:

* It would be great if we can add piglit.conf support to define where the 
vkrunner binary is. For example:

    [vkrunner]
    bin=<vkrunner_path>/build/src/vkrunner

* Please add some documentation on the README.md file like: where VkRunner can 
be cloned from, the environment variable, the piglit.conf change (see above), 
etc.

With these two changes, I think the patch series should be ready for its merge 
:-)

Sam

> The VkRunner repo can be found here:
> https://github.com/igalia/vkrunner
> 
> In the meantime since the last patch series, VkRunner has been
> continuously developed and has gained features. Notably for Piglit, it
> now works on Windows including building with Visual Studio. It has
> also switched to using CMake for the build system.
> 
> Neil Roberts (2):
>   framework: Add a vulkan tests profile
>   vulkan: Add some tests for glsl450 builtin functions using doubles
> 
>  framework/test/piglit_test.py                 | 17 ++++
>  tests/vulkan.py                               | 33 +++++++
>  .../face-forward-double.vk_shader_test        | 88 +++++++++++++++++++
>  .../glsl450/frexp-double.vk_shader_test       | 61 +++++++++++++
>  .../glsl450/isinf-double.vk_shader_test       | 81 +++++++++++++++++
>  .../glsl450/reflect-double.vk_shader_test     | 55 ++++++++++++
>  .../glsl450/refract-double.vk_shader_test     | 88 +++++++++++++++++++
>  7 files changed, 423 insertions(+)
>  create mode 100644 tests/vulkan.py
>  create mode 100644 tests/vulkan/glsl450/face-forward-double.vk_shader_test
>  create mode 100644 tests/vulkan/glsl450/frexp-double.vk_shader_test
>  create mode 100644 tests/vulkan/glsl450/isinf-double.vk_shader_test
>  create mode 100644 tests/vulkan/glsl450/reflect-double.vk_shader_test
>  create mode 100644 tests/vulkan/glsl450/refract-double.vk_shader_test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20181105/b78b2feb/attachment.sig>