[Piglit] [PATCH 00/10] port NV_conditional_render tests to GLES3

Ilia Mirkin imirkin at alum.mit.edu
Mon Nov 5 18:34:56 UTC 2018


I've gone over all of these and they look fine. However as I pointed
out, they should be targeted at ES2 instead (and tested with an
ES2-forced profile). I also saw the same shaders over and over -- I
might have put them into a common.c or something so as not to repeat
them 20x. OTOH they're relatively short, so it's also fine the way you
have it.

Cheers,

  -ilia
On Mon, Nov 5, 2018 at 12:23 PM Erik Faye-Lund
<erik.faye-lund at collabora.com> wrote:
>
> The NV_conditional_render spec allows for the extension to be
> implemented on top of OpenGL ES 3.0. So let's port the tests so they can
> run there as well.
>
> Erik Faye-Lund (10):
>   nv_conditional_render: fixup test-requirements
>   nv_conditional_render: drop mipmapping from tests that doesn't care
>   nv_conditional_render: do not depend on float-textures
>   nv_conditional_render: port tests to gles3
>   nv_conditional_render: port blitframebuffer-test to gles3
>   nv_conditional_render: port clear-test to gles3
>   nv_conditional_render: port copyteximage-test to gles3
>   nv_conditional_render: port copytexsubimage-test to gles3
>   nv_conditional_render: port generatemipmap-test to gles3
>   nv_conditional_render: port vertex_array-test to gles3
>
>  .../CMakeLists.gles3.txt                      | 12 +++
>  .../begin-while-active.c                      |  7 +-
>  tests/spec/nv_conditional_render/begin-zero.c |  7 +-
>  tests/spec/nv_conditional_render/bitmap.c     |  2 -
>  .../nv_conditional_render/blitframebuffer.c   | 80 ++++++++++++++++---
>  tests/spec/nv_conditional_render/clear.c      | 36 ++++++++-
>  tests/spec/nv_conditional_render/copypixels.c |  2 -
>  .../spec/nv_conditional_render/copyteximage.c | 70 +++++++++++++---
>  .../nv_conditional_render/copytexsubimage.c   | 70 +++++++++++++---
>  tests/spec/nv_conditional_render/dlist.c      |  2 -
>  tests/spec/nv_conditional_render/drawpixels.c |  2 -
>  .../nv_conditional_render/generatemipmap.c    | 61 +++++++++++---
>  .../spec/nv_conditional_render/vertex_array.c | 47 ++++++++++-
>  13 files changed, 337 insertions(+), 61 deletions(-)
>  create mode 100644 tests/spec/nv_conditional_render/CMakeLists.gles3.txt
>
> --
> 2.19.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list