[Piglit] [PATCH] framework: fix python2

Dylan Baker dylan at pnwbakers.com
Thu Nov 8 17:31:42 UTC 2018


Quoting Eric Engestrom (2018-11-08 09:23:51)
> The non-ascii char broke the python2 CI:
> https://travis-ci.org/mesa3d/piglit/jobs/452170869
> 
> Fixes: 221d924689e3bb2796ce "framework: Add a vulkan tests profile"
> Cc: Neil Roberts <nroberts at igalia.com>
> Cc: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> Cc: Dylan Baker <dylan at pnwbakers.com>
> Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> ---
>  framework/test/piglit_test.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/test/piglit_test.py b/framework/test/piglit_test.py
> index c80e355d184fb46ef0d8..83398bf6a719ade2e32c 100644
> --- a/framework/test/piglit_test.py
> +++ b/framework/test/piglit_test.py
> @@ -248,7 +248,7 @@ def __init__(self, filename):
>  
>      @PiglitBaseTest.command.getter
>      def command(self):
> -        # This is overriden because we don\u2019t want PiglitBaseTest to
> +        # This is overriden because we don't want PiglitBaseTest to

That should just be a plain ', not a unicode, so we should fix that

Also, just adding: #encoding=utf-8
to the top will ifx that as well. If we're not doing that to all
of the piglit scripts we should.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20181108/59039cc3/attachment.sig>


More information about the Piglit mailing list