[Piglit] [PATCH] vulkan: Prefix group names for VkRunner tests with “vulkan”

Neil Roberts nroberts at igalia.com
Tue Nov 13 20:50:16 UTC 2018

This will make it easier to distinguish tests written for Vulkan. It
makes a bit of an inconsistency because the GL and CL tests don’t have
any prefix. Ideally maybe we would add a prefix for those too, but
changing the test names at this late stage would probably cause a lot
of hassle.

Adding the prefix will avoid problems if we eventually decide to merge
the Vulkan profile into the “quick” profile because otherwise we risk
having name collisions when the same thing is tested on both Vulkan
and GL.
 tests/vulkan.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/vulkan.py b/tests/vulkan.py
index eed199c55..ae01677a9 100644
--- a/tests/vulkan.py
+++ b/tests/vulkan.py
@@ -21,7 +21,8 @@ profile = TestProfile()
     _basedir = os.path.join(basedir, 'vulkan')
     for dirpath, _, filenames in os.walk(_basedir):
-        groupname = grouptools.from_path(os.path.relpath(dirpath, _basedir))
+        groupname = ('vulkan' + grouptools.SEPARATOR +
+                     grouptools.from_path(os.path.relpath(dirpath, _basedir)))
         dirname = os.path.relpath(dirpath, os.path.join(basedir, '..'))
         for filename in filenames:
             testname, ext = os.path.splitext(filename)

More information about the Piglit mailing list