[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: fix error check with unknown drm format

Eric Anholt eric at anholt.net
Tue Nov 13 23:27:15 UTC 2018


Lionel Landwerlin <lionel.g.landwerlin at intel.com> writes:

> According to the EGL_EXT_image_dma_buf_import spec, creating an EGL
> image with a DRM format not supported should yield the BAD_MATCH
> error :
>
> "
>        * If <target> is EGL_LINUX_DMA_BUF_EXT, and the EGL_LINUX_DRM_FOURCC_EXT
>          attribute is set to a format not supported by the EGL, EGL_BAD_MATCH
>          is generated.
> "
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Fixes: 0ee445dbbc161f ("tests/spec: EXT_image_dma_buf_import invalid attributes")

If you include that spec citation as a comment in the same style as say,
test_buffer_not_null()'s, it gets my r-b.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20181113/6ddac3b1/attachment-0001.sig>


More information about the Piglit mailing list