[Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: fix error check with unknown drm format
Lionel Landwerlin
lionel.g.landwerlin at intel.com
Wed Nov 14 11:10:14 UTC 2018
According to the EGL_EXT_image_dma_buf_import spec, creating an EGL
image with a DRM format not supported should yield the BAD_MATCH
error :
"
* If <target> is EGL_LINUX_DMA_BUF_EXT, and the EGL_LINUX_DRM_FOURCC_EXT
attribute is set to a format not supported by the EGL, EGL_BAD_MATCH
is generated.
"
v2: Add spec quote (Eric)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 0ee445dbbc161f ("tests/spec: EXT_image_dma_buf_import invalid attributes")
---
tests/spec/ext_image_dma_buf_import/invalid_attributes.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/spec/ext_image_dma_buf_import/invalid_attributes.c b/tests/spec/ext_image_dma_buf_import/invalid_attributes.c
index cc0b0462a..e4bc78f7d 100644
--- a/tests/spec/ext_image_dma_buf_import/invalid_attributes.c
+++ b/tests/spec/ext_image_dma_buf_import/invalid_attributes.c
@@ -162,10 +162,17 @@ test_invalid_format(unsigned w, unsigned h, int fd, unsigned stride,
EGL_NONE
};
+ /**
+ * The spec says:
+ *
+ * "If <target> is EGL_LINUX_DMA_BUF_EXT, and the EGL_LINUX_DRM_FOURCC_EXT
+ * attribute is set to a format not supported by the EGL, EGL_BAD_MATCH
+ * is generated."
+ */
img = eglCreateImageKHR(eglGetCurrentDisplay(), EGL_NO_CONTEXT,
EGL_LINUX_DMA_BUF_EXT, (EGLClientBuffer)0, attr);
- if (!piglit_check_egl_error(EGL_BAD_ATTRIBUTE)) {
+ if (!piglit_check_egl_error(EGL_BAD_MATCH)) {
if (img)
eglDestroyImageKHR(eglGetCurrentDisplay(), img);
return false;
--
2.19.1
More information about the Piglit
mailing list