[Piglit] [PATCH] tests: only run rounding tests if FE_UPWARD is present
eric.engestrom at intel.com
Fri Nov 30 18:41:29 UTC 2018
On Friday, 2018-11-30 18:31:16 +0000, Burton, Ross wrote:
> On Fri, 30 Nov 2018 at 17:44, Eric Engestrom <eric.engestrom at intel.com> wrote:
> > On Friday, 2018-11-30 16:33:23 +0000, Ross Burton wrote:
> > > On ARM, musl does not define FE_* when the architecture does not have VFP (which
> > > is the right interpretation).
> > >
> > > As these tests depend on calling fesetround(), skip the test if FE_UPWARD isn't
> > > available.
> > >
> > > Signed-off-by: Ross Burton <ross.burton at intel.com>
> > Maybe add to the commit message when pushing:
> > From the fesetround(3) man page:
> > > Each of the macros FE_TONEAREST, FE_UPWARD, FE_DOWNWARD, and
> > > FE_TOWARDZERO is defined when the implementation supports getting
> > > and setting the corresponding rounding direction.
> > Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
> I can revise the message and re-submit, but I can't push to piglit.
It's fine, I'll do that when I push it on Monday, unless someone beats
me to it :P
More information about the Piglit