[Piglit] [PATCH v2 3/6] s3tc-teximage: port to gles2

Emil Velikov emil.l.velikov at gmail.com
Fri Oct 26 16:50:55 UTC 2018

Hi Erik,

On Fri, 26 Oct 2018 at 14:03, Erik Faye-Lund
<erik.faye-lund at collabora.com> wrote:

> +
>         piglit_ortho_projection(piglit_width, piglit_height, GL_FALSE);
> +
> +
> +       tex_program = piglit_build_simple_program(vs_source, fs_source);
> +       glUseProgram(tex_program);
> +       GLint proj_loc = glGetUniformLocation(tex_program, "proj");
> +       piglit_ortho_uniform(proj_loc, piglit_width, piglit_height);
> +

I cannot spot anything wrong with the updated series, so sharing a
wondering thought.

Should we shouldn't fold this ES2 solution within the
piglit_ortho_projection it already already supports GLES1.
The helper library gets built in four flavours (gl, gles1, gles2,
gles3), so the usual #ifdef approach should be just fine.

There are some existing users of piglit_ortho_uniform, but t wouldn't
bother with them.


More information about the Piglit mailing list