[Piglit] [PATCH 1/2] sanity: Turn shader_test list into a string

[Dylan Baker]

Quoting Caio Marcelo de Oliveira Filho (2018-09-21 16:05:37)
> > > -add_shader_test('tests/shaders/glsl-algebraic-add-zero.shader_test')
> > > -add_shader_test('tests/spec/glsl-1.50/execution/geometry-basic.shader_test')
> > > -add_shader_test('tests/spec/arb_tessellation_shader/execution/sanity.shader_test')
> > > -add_shader_test('tests/spec/arb_compute_shader/execution/basic-ssbo.shader_test')
> > > +shader_tests = '''
> > > +tests/shaders/glsl-algebraic-add-zero.shader_test
> > > +tests/spec/arb_compute_shader/execution/basic-ssbo.shader_test
> > > +tests/spec/arb_tessellation_shader/execution/sanity.shader_test
> > > +tests/spec/glsl-1.50/execution/geometry-basic.shader_test
> > > +'''
> > 
> > How about a list of strings?
> 
> One string + split() gives less boilerplate per line. In this case
> either should be fine.

4 characters per line isn't that much boilerplate; and you're not writing what
you mean as-is. I'm not NAKing, but I still don't like it :)

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180921/4495b670/attachment.sig>