[Piglit] [PATCH 08/10] arb_separate_shader_objects: add unused location qualified input test

Andres Gomez agomez at igalia.com
Fri Feb 1 17:55:22 UTC 2019


New tests to check that an unused input varying, which would be
matched based on its explicit location, won't cause a link failure if
there is no matching output variable.

>From the ARB_separate_shader_objects spec v.25:

  "   * An output variable is considered to match an input variable in
        the subequent shader if:

        * the two variables match in name, type, and qualification; or

        * the two variables are declared with the same location layout
          qualifier and match in type and qualification."

  ...

  " For program objects containing multiple shaders, LinkProgram will
    check for mismatches on interfaces between shader stages in the
    program being linked and generate a link error if a mismatch is
    detected.  A link error will be generated if any statically
    referenced input variable or block does not have a matching
    output."

Cc: Timothy Arceri <tarceri at itsqueeze.com>
Cc: Iago Toral Quiroga <itoral at igalia.com>
Cc: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
Cc: Tapani Pälli <tapani.palli at intel.com>
Cc: Ian Romanick <ian.d.romanick at intel.com>
Signed-off-by: Andres Gomez <agomez at igalia.com>
---
 ...explicit-location-unused-input.shader_test | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 tests/spec/arb_separate_shader_objects/linker/vs-to-fs-explicit-location-unused-input.shader_test

diff --git a/tests/spec/arb_separate_shader_objects/linker/vs-to-fs-explicit-location-unused-input.shader_test b/tests/spec/arb_separate_shader_objects/linker/vs-to-fs-explicit-location-unused-input.shader_test
new file mode 100644
index 000000000..c39fd4033
--- /dev/null
+++ b/tests/spec/arb_separate_shader_objects/linker/vs-to-fs-explicit-location-unused-input.shader_test
@@ -0,0 +1,38 @@
+// From the ARB_separate_shader_objects spec v.25:
+//
+//   "   * An output variable is considered to match an input variable
+//         in the subequent shader if:
+//
+//         * the two variables match in name, type, and qualification;
+//           or
+//
+//         * the two variables are declared with the same location
+//           layout qualifier and match in type and qualification."
+//
+//   ...
+//
+//   " For program objects containing multiple shaders, LinkProgram
+//     will check for mismatches on interfaces between shader stages
+//     in the program being linked and generate a link error if a
+//     mismatch is detected.  A link error will be generated if any
+//     statically referenced input variable or block does not have a
+//     matching output."
+
+[require]
+GLSL >= 1.40
+GL_ARB_separate_shader_objects
+
+[vertex shader passthrough]
+
+[fragment shader]
+#version 140
+#extension GL_ARB_separate_shader_objects : require
+
+layout(location = 0) in vec4 in1;
+
+void main()
+{
+}
+
+[test]
+link success
-- 
2.20.1



More information about the Piglit mailing list