[Piglit] [PATCH] arb_texture_multisample: Tests working texelFetch() with DSA style

[Ilia Mirkin]

On Tue, Feb 12, 2019 at 7:53 AM Illia Iorin <illia.iorin at gmail.com> wrote:
>
> Test that texelFetch() correct works with DSA style and different texture
> types. Draw data into MS texture than read them to rect texture.
>
> Signed-off-by: Illia Iorin <illia.iorin at globallogic.com>
> ---
>  tests/opengl.py                               |   1 +
>  .../arb_texture_multisample/CMakeLists.gl.txt |   1 +
>  .../arb_texture_multisample/dsa-texelfetch.c  | 296 ++++++++++++++++++
>  3 files changed, 298 insertions(+)
>  create mode 100644 tests/spec/arb_texture_multisample/dsa-texelfetch.c
>
> diff --git a/tests/opengl.py b/tests/opengl.py
> index af68560bf..40fce09ef 100644
> --- a/tests/opengl.py
> +++ b/tests/opengl.py
> @@ -1558,6 +1558,7 @@ with profile.test_list.group_manager(
>      for sample_count in MSAA_SAMPLE_COUNTS:
>          g(['arb_texture_multisample-texelfetch', sample_count])
>      g(['arb_texture_multisample-sample-mask'])
> +    g(['arb_texture_multisample-dsa-texelfetch'])
>      g(['arb_texture_multisample-sample-mask-value'])
>      g(['arb_texture_multisample-sample-mask-execution'])
>      g(['arb_texture_multisample-sample-mask-execution', '-tex'])
> diff --git a/tests/spec/arb_texture_multisample/CMakeLists.gl.txt b/tests/spec/arb_texture_multisample/CMakeLists.gl.txt
> index 31965c4dc..903051ae8 100644
> --- a/tests/spec/arb_texture_multisample/CMakeLists.gl.txt
> +++ b/tests/spec/arb_texture_multisample/CMakeLists.gl.txt
> @@ -9,6 +9,7 @@ link_libraries (
>         ${OPENGL_gl_LIBRARY}
>  )
>
> +piglit_add_executable (arb_texture_multisample-dsa-texelfetch dsa-texelfetch.c)
>  piglit_add_executable (arb_texture_multisample-large-float-texture large-float-texture.c)
>  piglit_add_executable (arb_texture_multisample-minmax minmax.c)
>  piglit_add_executable (arb_texture_multisample-errors errors.c)
> diff --git a/tests/spec/arb_texture_multisample/dsa-texelfetch.c b/tests/spec/arb_texture_multisample/dsa-texelfetch.c
> new file mode 100644
> index 000000000..a96c42cdc
> --- /dev/null
> +++ b/tests/spec/arb_texture_multisample/dsa-texelfetch.c
> @@ -0,0 +1,296 @@
> +/*
> + * Copyright 2019 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + */
> +
> +
> +/**
> + * File: dsa-texelfetch.c
> + * Tests that texelFetch() gets texels from texture with different
> + * internal types.
> + *
> + *
> + * We populate an MS texture then we draw into
> + * a rectangle texture with values from the MS texture.
> + * We check that the data from rectangle texture is equal
> + * with the data in the MS texture.
> + *
> + * Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109057
> + */
> +
> +#include "piglit-util-gl.h"
> +
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +    config.supports_gl_core_version = 45;

This would require a GL 4.5 driver. However all you seem to require is
GLSL 3.30, and even that could be dropped to 140 + #enable
GL_ARB_texture_multisample... this should be the min GL version
requirement, and then you can check for additional extensions (as you
already do -- good).

  -ilia