[Piglit] [PATCH v1 1/2] piglit-framework-gl: add possibility to deinit test

Sergii Romantsov sergii.romantsov at gmail.com
Tue Jan 8 15:56:59 UTC 2019


Hello, Eric.
Yes, and i also answered with some explanation:

> And, in general, I would recommend just freeing data after usage,> rather than having a deinit function.

Looks like it may complicate a logic and code of test. Test may exit with
any call to 'piglit_report_result' and it can happens on any stage of
execution. In proposed mechanism we shouldn't care when and why exit is
done, so we can be sure that all resources will be freed.

But if it is not an argument - will update on this week like you have
suggested.

On Thu, Jan 3, 2019 at 8:42 PM Eric Anholt <eric at anholt.net> wrote:

> Sergii Romantsov <sergii.romantsov at gmail.com> writes:
>
> > Hello,
> > is there any chance to get review?
> > In the goal is idea to get a simple mechanism to control resources
> freeing
> > (any extra memory allocations, files etc.) of any piglit-test on the
> exit.
>
> I gave some feedback, and I haven't seen a new version.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20190108/50edbd95/attachment.html>


More information about the Piglit mailing list