[Piglit] [PATCH] Test that ES frag shader with invariant outputs compiles

Dylan Baker dylan at pnwbakers.com
Thu Jan 10 17:17:47 UTC 2019


I missed Tim's email, please ignore this.

Quoting Dylan Baker (2019-01-10 09:16:42)
> Please do not put anything in tests/glslparsertest/, these tests belong in in
> tests/spec/glsl-es-1.00 and tests/spec/glsl-es-3.00 respectively.
> 
> Quoting Danylo Piliaiev (2019-01-09 09:35:16)
> > In all GLSL ES versions output variables in fragment shader are allowed
> > to be invariant.
> > 
> >  From Section 4.6.1 ("The Invariant Qualifier") GLSL ES 1.00 spec:
> >  "Only the following variables may be declared as invariant:
> >    ...
> >    - Built-in special variables output from the fragment shader."
> > 
> >  From Section 4.6.1 ("The Invariant Qualifier") GLSL ES 3.00 spec:
> >  "Only variables output from a shader can be candidates for invariance."
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107842
> > 
> > Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
> > ---
> >  .../glslparsertest/shaders/invariant.V100.frag | 18 ++++++++++++++++++
> >  .../glslparsertest/shaders/invariant.V300.frag | 16 ++++++++++++++++
> >  2 files changed, 34 insertions(+)
> >  create mode 100644 tests/glslparsertest/shaders/invariant.V100.frag
> >  create mode 100644 tests/glslparsertest/shaders/invariant.V300.frag
> > 
> > diff --git a/tests/glslparsertest/shaders/invariant.V100.frag b/tests/glslparsertest/shaders/invariant.V100.frag
> > new file mode 100644
> > index 000000000..a6463d1dd
> > --- /dev/null
> > +++ b/tests/glslparsertest/shaders/invariant.V100.frag
> > @@ -0,0 +1,18 @@
> > +// [config]
> > +// expect_result: pass
> > +// glsl_version: 1.00
> > +//
> > +// [end config]
> > +
> > +/* From Section 4.6.1 ("The Invariant Qualifier") GLSL ES 1.00 spec:
> > + *
> > + *     "Only the following variables may be declared as invariant:
> > + *      Built-in special variables output from the fragment shader."
> > + */
> > +
> > +#version 100
> > +
> > +invariant gl_FragColor;
> > +invariant gl_FragData;
> > +
> > +void main() { }
> > diff --git a/tests/glslparsertest/shaders/invariant.V300.frag b/tests/glslparsertest/shaders/invariant.V300.frag
> > new file mode 100644
> > index 000000000..8d7707d8c
> > --- /dev/null
> > +++ b/tests/glslparsertest/shaders/invariant.V300.frag
> > @@ -0,0 +1,16 @@
> > +// [config]
> > +// expect_result: pass
> > +// glsl_version: 3.00
> > +//
> > +// [end config]
> > +
> > +/* From Section 4.6.1 ("The Invariant Qualifier") GLSL ES 3.00 spec:
> > + *
> > + *     "Only variables output from a shader can be candidates for invariance."
> > + */
> > +
> > +#version 300 es
> > +
> > +invariant out highp vec4 test;
> > +
> > +void main() { }
> > -- 
> > 2.20.1
> > 
> > _______________________________________________
> > Piglit mailing list
> > Piglit at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20190110/961b71e8/attachment.sig>


More information about the Piglit mailing list