[Piglit] [PATCH v3] miptree: test ability to use upside down miptree
asimiklit.work at gmail.com
Fri Jan 11 15:28:16 UTC 2019
Thanks for review.
Could somebody help me with a push?
Yes, you are right about missing 'in-' in 'git send-email --in-reply-to='.
So v3 wasn't added to the patchwork(
Hope it isn't really mandatory and the push can be performed)
On Fri, Jan 11, 2019 at 3:14 PM Emil Velikov <emil.l.velikov at gmail.com>
> On 2018/12/12, asimiklit.work at gmail.com wrote:
> > From: Andrii Simiklit <andrii.simiklit at globallogic.com>
> > Test that usage of upside down miptree doesn't cause assertion
> > The miptree:
> > level 0 = 1x1
> > level 1 = 2x2
> > level 2 = 4x4
> > ...
> > level n = NxN
> > should be acceptable for case when we don't use a min filter.
> > v2: - Unnecessary function calls were removed
> > - The 'glClearColor' call was moved to 'piglit_display' function
> > - The program creation was moved to 'piglit_init' function
> > - The requirements check was moved to 'piglit_init' function
> > ( Erik Faye-Lund <erik.faye-lund at collabora.com> )
> > - Fixed a leak of texture which is created in 'setup_texture'
> > v3: - Defined a constant for the test color instead of a hardcoded
> > - Removed unused variable 'pos' which is always was 0
> > - Implemented more effective number of levels calculator
> > - Removed a stop when one of tests fails
> > - Fixed two style issues
> > ( Emil Velikov <emil.l.velikov at gmail.com> )
> Looks great, thank you.
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
> P.S. Seems like you're missing "in-" from the git send-email
> --in-reply-to="old-thread-id" ...
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Piglit