From jfonseca at vmware.com Tue May 5 14:40:54 2020 From: jfonseca at vmware.com (Jose Fonseca) Date: Tue, 5 May 2020 14:40:54 +0000 Subject: [Piglit] Vulkan headers dependency In-Reply-To: <2120213620.3693.1588689178677.JavaMail.hudson@id-hudson.eng.vmware.com> References: <2120213620.3693.1588689178677.JavaMail.hudson@id-hudson.eng.vmware.com> Message-ID: Hi Eleni, Could we please make Vulkan headers an optional dependency? It would simplify building and running piglit on Windows. Jose ________________________________________ Sent: Tuesday, May 5, 2020 15:32 piglit-mingw32 - Build # 3770 - Failure: Log: [...truncated 47 lines...] ^~~~~~~~~~~~~~~~~ compilation terminated. [9/23] Building C object target_api/gl/tests/spec/ext_external_objects/CMakeFiles/ext_external_objects-vk-image-override.dir/interop.c.obj FAILED: target_api/gl/tests/spec/ext_external_objects/CMakeFiles/ext_external_objects-vk-image-override.dir/interop.c.obj /usr/bin/i686-w64-mingw32-gcc -DGLAPIENTRY=__stdcall -DNOMINMAX -DPIGLIT_HAS_PTHREADS -DPIGLIT_HAS_WGL -DPIGLIT_USE_OPENGL -DPIGLIT_USE_WAFFLE -DVK_BANDS_FRAG=\"/var/lib/hudson/jobs/piglit-mingw32/workspace/target_api/gl/tests/spec/ext_external_objects/vk_bands.frag.spv\" -DVK_BANDS_VERT=\"/var/lib/hudson/jobs/piglit-mingw32/workspace/target_api/gl/tests/spec/ext_external_objects/vk_bands.vert.spv\" -DWAFFLE_API_VERSION=0x0103 -DWIN32_LEAN_AND_MEAN=1 -D_GNU_SOURCE -D_USE_MATH_DEFINES -Isrc -Itests/util -I/var/lib/hudson/tools/mingw32/glext -Wall -std=gnu99 -Werror=vla -Werror=pointer-arith -Werror=variadic-macros -Os -DNDEBUG -MD -MT target_api/gl/tests/spec/ext_external_objects/CMakeFiles/ext_external_objects-vk-image-override.dir/interop.c.obj -MF target_api/gl/tests/spec/ext_external_objects/CMakeFiles/ext_external_objects-vk-image-override.dir/interop.c.obj.d -o target_api/gl/tests/spec/ext_external_objects/CMakeFiles/ext_external_objects-vk-image-override.dir/interop.c.obj -c tests/spec/ext_external_objects/interop.c In file included from tests/spec/ext_external_objects/interop.h:32:0, from tests/spec/ext_external_objects/interop.c:30: tests/spec/ext_external_objects/vk.h:30:10: fatal error: vulkan/vulkan.h: No such file or directory #include ^~~~~~~~~~~~~~~~~ compilation terminated. [10/23] Building C object target_api/gl/tests/spec/ext_external_objects_fd/CMakeFiles/ext_external_objects_fd-memory-object-api-errors.dir/memory-object-api-errors.c.obj [11/23] Building C object target_api/gl/tests/spec/ext_external_objects_fd/CMakeFiles/ext_external_objects_fd-semaphore-api-errors.dir/semaphore-api-errors.c.obj [12/23] Building C object target_api/gl/tests/spec/ext_external_objects/CMakeFiles/ext_external_objects-semaphore-api-errors.dir/semaphore-api-errors.c.obj [13/23] Building C object target_api/gl/tests/spec/ext_external_objects/CMakeFiles/ext_external_objects-memory-object-api-errors.dir/memory-object-api-errors.c.obj [14/23] Generating ../../../tests/opengl.xml.gz ninja: build stopped: subcommand failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Archiving artifacts Email was triggered for: Failure - 1st Trigger Failure - Any was overridden by another trigger and will not send an email. Trigger Failure - Still was overridden by another trigger and will not send an email. Sending email for trigger: Failure - 1st Changes: Changes for Build #3770 [estea] ext_external_objects: Group external object tests [estea] ext_external_objects: Add Vulkan helpers [estea] ext_external_objects: Add Vulkan-OpenGL interoperability helpers [estea] ext_external_objects: Extended the interoperability and Vulkan helpers [estea] ext_external_objects: Add Vulkan/OpenGL driver compatibility checker [estea] ext_external_objects: Helper structs that map the Vk and GL formats [estea] ext_external_objects/vk-image-override: Add a Vulkan-GL test [estea] ext_external_objects/vk-image-override: New approach to test formats [estea] ext_external_objects/vk-image-display: Add a new Vulkan->OpenGL test [estea] gitlab-ci: add libvulkan-dev to support tests that use Vulkan -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: ATT00001.txt URL: From lionel.g.landwerlin at intel.com Tue May 5 14:46:17 2020 From: lionel.g.landwerlin at intel.com (Lionel Landwerlin) Date: Tue, 5 May 2020 17:46:17 +0300 Subject: [Piglit] Vulkan headers dependency In-Reply-To: References: <2120213620.3693.1588689178677.JavaMail.hudson@id-hudson.eng.vmware.com> Message-ID: Maybe embedding them like we do in Mesa? -Lionel On 05/05/2020 17:40, Jose Fonseca wrote: > Could we please make Vulkan headers an optional dependency?? It would > simplify building and running piglit on Windows. -------------- next part -------------- An HTML attachment was scrubbed... URL: From jfonseca at vmware.com Tue May 5 14:53:07 2020 From: jfonseca at vmware.com (Jose Fonseca) Date: Tue, 5 May 2020 14:53:07 +0000 Subject: [Piglit] Vulkan headers dependency In-Reply-To: References: <2120213620.3693.1588689178677.JavaMail.hudson@id-hudson.eng.vmware.com> , Message-ID: That would work too. It's not difficult to make vulkan headers an optional dependency FWIW. IIUC, modifying tests/spec/ext_external_objects/CMakeLists.gl.txt and enclosing all in if (LIBVULKAN_FOUND) ... endif () , or something along those lines, should do the trick. I'm pretty sure there are lots of precedents for tests being optionally built. Jose ________________________________ From: Lionel Landwerlin Sent: Tuesday, May 5, 2020 15:46 To: Jose Fonseca ; Eleni Maria Stea Cc: piglit at lists.freedesktop.org Subject: Re: [Piglit] Vulkan headers dependency Maybe embedding them like we do in Mesa? -Lionel On 05/05/2020 17:40, Jose Fonseca wrote: Could we please make Vulkan headers an optional dependency? It would simplify building and running piglit on Windows. -------------- next part -------------- An HTML attachment was scrubbed... URL: From estea at igalia.com Tue May 5 20:13:30 2020 From: estea at igalia.com (Eleni Maria Stea) Date: Tue, 5 May 2020 23:13:30 +0300 Subject: [Piglit] Vulkan headers dependency In-Reply-To: References: <2120213620.3693.1588689178677.JavaMail.hudson@id-hudson.eng.vmware.com> Message-ID: <20200505231330.363894a7@tiktok> On Tue, 5 May 2020 14:53:07 +0000 Jose Fonseca wrote: > That would work too. > > It's not difficult to make vulkan headers an optional dependency > FWIW. IIUC, modifying > tests/spec/ext_external_objects/CMakeLists.gl.txt and enclosing all > in if (LIBVULKAN_FOUND) ... endif () , or something along those > lines, should do the trick. I'm pretty sure there are lots of > precedents for tests being optionally built. > > Jose > > ________________________________ > From: Lionel Landwerlin > Sent: Tuesday, May 5, 2020 15:46 > To: Jose Fonseca ; Eleni Maria Stea > Cc: piglit at lists.freedesktop.org > Subject: Re: [Piglit] Vulkan headers > dependency > > Maybe embedding them like we do in Mesa? > > -Lionel > > On 05/05/2020 17:40, Jose Fonseca wrote: > Could we please make Vulkan headers an optional dependency? It would > simplify building and running piglit on Windows. > Hello, Apologies for breaking the Windows build! I've submitted a new merge request with a fix: https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/282 Eleni