<div dir="ltr">Pinging for comment regarding patch v3. Thank you.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 14, 2016 at 4:09 PM, Haixia Shi <span dir="ltr"><<a href="mailto:hshi@chromium.org" target="_blank">hshi@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">The function GLboolean piglit_check_gl_error() returns GL_TRUE when there is<br>
no error, and GL_FALSE when there is an error.<br>
<br>
</span>v3: edited according to Ian's comments.<br>
<span class=""><br>
Signed-off-by: Haixia Shi <<a href="mailto:hshi@chromium.org">hshi@chromium.org</a>><br>
Cc: Dylan Baker <<a href="mailto:baker.dylan.c@gmail.com">baker.dylan.c@gmail.com</a>><br>
Cc: Ian Romanick <<a href="mailto:idr@freedesktop.org">idr@freedesktop.org</a>><br>
---<br>
</span> tests/spec/arb_get_program_binary/retrievable_hint.c | 4 +---<br>
1 file changed, 1 insertion(+), 3 deletions(-)<br>
<br>
diff --git a/tests/spec/arb_get_program_binary/retrievable_hint.c b/tests/spec/arb_get_program_binary/retrievable_hint.c<br>
index 8283c5b..8155ac0 100644<br>
--- a/tests/spec/arb_get_program_binary/retrievable_hint.c<br>
+++ b/tests/spec/arb_get_program_binary/retrievable_hint.c<br>
@@ -63,7 +63,6 @@ piglit_init(int argc, char **argv)<br>
GLuint prog;<br>
GLint value;<br>
bool pass = true;<br>
- bool got_error;<br>
<br>
piglit_require_gl_version(20);<br>
piglit_require_extension("GL_ARB_get_program_binary");<br>
@@ -79,9 +78,8 @@ piglit_init(int argc, char **argv)<br>
<span class=""> */<br>
value = 0xDEADBEEF;<br>
glGetProgramiv(prog, GL_PROGRAM_BINARY_RETRIEVABLE_HINT, &value);<br>
- got_error = piglit_check_gl_error(0);<br>
<br>
</span>- if (!got_error) {<br>
+ if (piglit_check_gl_error(GL_NO_ERROR)) {<br>
if (value == 0xDEADBEEF) {<br>
fprintf(stderr,<br>
"No error generated for "<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.8.0.rc3.226.g39d4020<br>
<br>
</font></span></blockquote></div><br></div>