<p dir="ltr">Yeah, split seems fine. Reviewed-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>></p>
<div class="gmail_quote">On May 9, 2016 2:41 AM, "Eduardo Lima Mitev" <<a href="mailto:elima@igalia.com">elima@igalia.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Ilia,<br>
<br>
Are you ok with the test split I did in v2?<br>
<br>
Thanks,<br>
Eduardo<br>
<br>
On 05/06/2016 08:29 AM, Eduardo Lima Mitev wrote:<br>
> There are missing tests to check for readonly and writeonly memory qualifiers<br>
> on a named interface block. And Mesa is actually failing to apply these<br>
> qualifiers right now.<br>
><br>
> v2: (Ilia Mirkin) Put each test case into its own shader file.<br>
> ---<br>
>  .../named-block-memory-qualifier-readonly-member.vert     | 15 +++++++++++++++<br>
>  .../compiler/named-block-memory-qualifier-readonly.vert   | 15 +++++++++++++++<br>
>  .../named-block-memory-qualifier-writeonly-member.vert    | 15 +++++++++++++++<br>
>  .../compiler/named-block-memory-qualifier-writeonly.vert  | 15 +++++++++++++++<br>
>  4 files changed, 60 insertions(+)<br>
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-readonly-member.vert<br>
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-readonly.vert<br>
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-writeonly-member.vert<br>
>  create mode 100644 tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-writeonly.vert<br>
><br>
> diff --git a/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-readonly-member.vert b/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-readonly-member.vert<br>
> new file mode 100644<br>
> index 0000000..c5af6c1<br>
> --- /dev/null<br>
> +++ b/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-readonly-member.vert<br>
> @@ -0,0 +1,15 @@<br>
> +// [config]<br>
> +// expect_result: fail<br>
> +// glsl_version: 3.30<br>
> +// require_extensions: GL_ARB_shader_storage_buffer_object<br>
> +// [end config]<br>
> +<br>
> +#version 330<br>
> +#extension GL_ARB_shader_storage_buffer_object: require<br>
> +buffer Buffer {<br>
> +     readonly float foo;<br>
> +} buf;<br>
> +<br>
> +void main() {<br>
> +     buf.foo = 1.0;<br>
> +}<br>
> diff --git a/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-readonly.vert b/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-readonly.vert<br>
> new file mode 100644<br>
> index 0000000..6145350<br>
> --- /dev/null<br>
> +++ b/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-readonly.vert<br>
> @@ -0,0 +1,15 @@<br>
> +// [config]<br>
> +// expect_result: fail<br>
> +// glsl_version: 3.30<br>
> +// require_extensions: GL_ARB_shader_storage_buffer_object<br>
> +// [end config]<br>
> +<br>
> +#version 330<br>
> +#extension GL_ARB_shader_storage_buffer_object: require<br>
> +readonly buffer Buffer {<br>
> +     float foo;<br>
> +} buf;<br>
> +<br>
> +void main() {<br>
> +     buf.foo = 1.0;<br>
> +}<br>
> diff --git a/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-writeonly-member.vert b/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-writeonly-member.vert<br>
> new file mode 100644<br>
> index 0000000..5b4c20a<br>
> --- /dev/null<br>
> +++ b/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-writeonly-member.vert<br>
> @@ -0,0 +1,15 @@<br>
> +// [config]<br>
> +// expect_result: fail<br>
> +// glsl_version: 3.30<br>
> +// require_extensions: GL_ARB_shader_storage_buffer_object<br>
> +// [end config]<br>
> +<br>
> +#version 330<br>
> +#extension GL_ARB_shader_storage_buffer_object: require<br>
> +buffer Buffer {<br>
> +     writeonly float foo;<br>
> +} buf;<br>
> +<br>
> +void main(void) {<br>
> +     float result = buf.foo;<br>
> +}<br>
> diff --git a/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-writeonly.vert b/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-writeonly.vert<br>
> new file mode 100644<br>
> index 0000000..d9ffc24<br>
> --- /dev/null<br>
> +++ b/tests/spec/arb_shader_storage_buffer_object/compiler/named-block-memory-qualifier-writeonly.vert<br>
> @@ -0,0 +1,15 @@<br>
> +// [config]<br>
> +// expect_result: fail<br>
> +// glsl_version: 3.30<br>
> +// require_extensions: GL_ARB_shader_storage_buffer_object<br>
> +// [end config]<br>
> +<br>
> +#version 330<br>
> +#extension GL_ARB_shader_storage_buffer_object: require<br>
> +writeonly buffer Buffer {<br>
> +     float foo;<br>
> +} buf;<br>
> +<br>
> +void main(void) {<br>
> +     float result = buf.foo;<br>
> +}<br>
><br>
<br>
</blockquote></div>