<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 22/07/16 14:31, Ilia Mirkin wrote:<br>
<blockquote
cite="mid:CAKb7Uvgp3r3WmwzS9m9gLjwMKZOSyTRTGdxjSnid0=K95m1aPQ@mail.gmail.com"
type="cite">
<p dir="ltr">What does this fix? </p>
</blockquote>
<br>
Nothing. It was just a change proposed by Dylan, and I just copied
the code he proposed.<br>
<br>
<blockquote
cite="mid:CAKb7Uvgp3r3WmwzS9m9gLjwMKZOSyTRTGdxjSnid0=K95m1aPQ@mail.gmail.com"
type="cite">
<p dir="ltr">IMO seems way harder to read. If you're really set on
using product, moving the array definitions out of line, with
descriptive names would solve that. E.g</p>
<p dir="ltr">RESOLUTIONS = [1,2,3]<br>
for resolution, ... in itertools.product():</p>
</blockquote>
<br>
Makes sense. I will send a v2 version in short.<br>
<br>
<blockquote
cite="mid:CAKb7Uvgp3r3WmwzS9m9gLjwMKZOSyTRTGdxjSnid0=K95m1aPQ@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Jul 22, 2016 2:09 AM, "Alejandro
Piñeiro" <<a moz-do-not-send="true"
href="mailto:apinheiro@igalia.com">apinheiro@igalia.com</a>>
wrote:<br type="attribution">
<blockquote class="quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
tests/all.py | 11 ++++-------<br>
1 file changed, 4 insertions(+), 7 deletions(-)<br>
<br>
diff --git a/tests/all.py b/tests/all.py<br>
index 2c78b0a..a29724e 100644<br>
--- a/tests/all.py<br>
+++ b/tests/all.py<br>
@@ -4722,13 +4722,10 @@ with profile.group_manager(<br>
with profile.group_manager(<br>
PiglitGLTest,<br>
grouptools.join('spec', 'arb_texture_barrier')) as
g:<br>
- for resolution in ['32', '512']:<br>
- for blend_passes in ['1', '42']:<br>
- for num_textures in ['1', '8']:<br>
- for granularity in ['8', '64', '128']:<br>
- for draw_passes in ['1', '2', '3', '4',
'7', '8']:<br>
-
g(['arb_texture_barrier-blending-in-shader', resolution,<br>
- blend_passes, num_textures,
granularity, draw_passes])<br>
+ for resolution, blend_passes, num_textures,
granularity, draw_passes in itertools.product(<br>
+ ['32', '512'], ['1', '42'], ['1', '8'], ['8',
'64', '128'], ['1', '2', '3', '4', '7', '8']):<br>
+ g(['arb_texture_barrier-blending-in-shader',
resolution,<br>
+ blend_passes, num_textures, granularity,
draw_passes])<br>
<br>
<br>
# Group ARB_invalidate_subdata<br>
<font color="#888888">--<br>
2.7.4<br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a moz-do-not-send="true"
href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a moz-do-not-send="true"
href="https://lists.freedesktop.org/mailman/listinfo/piglit"
rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</font></blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>