<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - piglit_drm_dma_buf.c:142:7: error: ‘DRM_FORMAT_R8’ undeclared (first use in this function)" href="https://bugs.freedesktop.org/show_bug.cgi?id=97951#c10">Comment # 10</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - piglit_drm_dma_buf.c:142:7: error: ‘DRM_FORMAT_R8’ undeclared (first use in this function)" href="https://bugs.freedesktop.org/show_bug.cgi?id=97951">bug 97951</a> from <a class="email" href="mailto:robclark@freedesktop.org" title="Rob Clark <robclark@freedesktop.org>"> Rob Clark</a> <pre>(In reply to Dylan Baker from <a href="show_bug.cgi?id=97951#c9">comment #9</a>) > > Err, that should be "if the GBM version is *not* new enough" (In reply to Dylan Baker from <a href="show_bug.cgi?id=97951#c8">comment #8</a>) > > I think the problem is further down: > > if(LIBDRM_FOUND AND XCB_DRI2_FOUND AND > ((LIBDRM_INTEL_VERSION VERSION_GREATER "2.4.37") OR > PIGLIT_HAS_GBM_BO_MAP)) > set(PIGLIT_BUILD_DMA_BUF_TESTS_IS_VALID true) > else() > set(PIGLIT_BUILD_DMA_BUF_TESTS_IS_VALID false) > endif() > > This will do what you expect on every piece of hardware, except Intel, where > if the GBM version is new enough it will still turn it on if the DRM_INTEL > version is also new enough. > > I think we just need to remove that LIBDRM_INTEL check (or modify it). oh, my bad.. I read the error message too quickly, as GBM_FORMAT_R8/etc.. not DRM_FORMAT_xyz. So that part won't be built unless you have -DPIGLIT_HAS_GBM_BO_MAP, so existing check is fine. The problem is actually that he has too old drm_fourcc.h I guess? Not sure what the best way to check for that would be..</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>