<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - piglit_drm_dma_buf.c:142:7: error: ‘DRM_FORMAT_R8’ undeclared (first use in this function)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=97951">97951</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>piglit_drm_dma_buf.c:142:7: error: ‘DRM_FORMAT_R8’ undeclared (first use in this function)
</td>
</tr>
<tr>
<th>Product</th>
<td>piglit
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>x86-64 (AMD64)
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux (All)
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Keywords</th>
<td>bisected, regression
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>piglit@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>vlee@freedesktop.org
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>piglit@lists.freedesktop.org
</td>
</tr>
<tr>
<th>CC</th>
<td>eric@anholt.net, krh@bitplanet.net, robclark@freedesktop.org
</td>
</tr></table>
<p>
<div>
<pre>piglit: 0222f5db00fd47fb745402514a6d8cf2747f8434 (master)
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c: In function
‘piglit_intel_buf_create’:
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:142:7: error:
‘DRM_FORMAT_R8’ undeclared (first use in this function)
case DRM_FORMAT_R8:
^
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:142:7: note: each
undeclared identifier is reported only once for each function it appears in
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:145:7: error:
‘DRM_FORMAT_GR88’ undeclared (first use in this function)
case DRM_FORMAT_GR88:
^
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:146:7: error:
‘DRM_FORMAT_RG88’ undeclared (first use in this function)
case DRM_FORMAT_RG88:
^
0222f5db00fd47fb745402514a6d8cf2747f8434 is the first bad commit
commit 0222f5db00fd47fb745402514a6d8cf2747f8434
Author: Rob Clark <<a href="mailto:robdclark@gmail.com">robdclark@gmail.com</a>>
Date: Sat Sep 3 15:16:31 2016 -0400
dmabuf: fix YUV tests for drivers other than intel
Ok, so the basic problem with the YUV tests is that they currently
completely ignore driver/hw pitch requirements, since the code that
allocates the buffer doesn't know the pixel format, only the 'cpp'.
The yuv test creates a small 4x4 yuv eglimage. If, say, the hardware
requires the pitch to be aligned to, say, 32pixels, everything is fine
for the Y plane, but the subsampled U/V or U+V plane has half as many
pixels. (This did help me catch a bug in driver, not rejecting the
dmabuf import with invalid pitch, but that doesn't help to get the
piglit tests running.)
The best approach I could come up with to fix this is to pass the
fourcc all the way down to the code that creates the dmabuf (and copies
src data into the dmabuf). Unfortunately this makes the patch a bit
bigger than I was hoping, and not really sure a good way to split it
up.
This is tested on i965 (with the intel dma-buf backend) and freedreno
(with the gbm dma-buf backend). In the gbm case, it requires new
gbm format values for R8 and GR88, which is on mesa master as of
this morning. (So I bumped the gbm version dependency to 12.1.)
Signed-off-by: Rob Clark <<a href="mailto:robdclark@gmail.com">robdclark@gmail.com</a>>
Reviewed-by: Eric Anholt <<a href="mailto:eric@anholt.net">eric@anholt.net</a>>
Reviewed-by: Kristian Høgsberg <<a href="mailto:krh@bitplanet.net">krh@bitplanet.net</a>>
:100644 100644 ce7f3f8aabc4884550b4d62ae738b8ed49a13131
4002fe9bf741e43377221021ade5faa51c3dea60 M CMakeLists.txt
:040000 040000 1cb176b53c8e3ed014824612b498e64c1fb393fc
7730a34ffac6886e43c48bd6b8df7ae3bb700d4b M tests
bisect run success</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>