<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""> <div><blockquote type="cite" class=""><div class="">On Dec 7, 2016, at 11:03, Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" class="">jan.vesely@rutgers.edu</a>> wrote:</div> <div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Tue, 2016-12-06 at 11:05 -0800, Matt Arsenault wrote:<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" class="">On Dec 6, 2016, at 11:04, Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" class="">jan.vesely@rutgers.edu</a>> wrote: On Tue, 2016-12-06 at 10:52 -0800, Matt Arsenault wrote: <blockquote type="cite" class=""><blockquote type="cite" class="">On Dec 5, 2016, at 12:42, Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" class="">jan.vesely@rutgers.edu</a>> wrote: On Mon, 2016-12-05 at 09:48 -0800, <a href="mailto:arsenm2@gmail.com" class="">arsenm2@gmail.com</a> <<a href="mailto:arsenm2@gmail.com" class="">mailto:arsenm2@gmail.com</a>> wrote: <blockquote type="cite" class="">From: Matt Arsenault <<a href="mailto:arsenm2@gmail.com" class="">arsenm2@gmail.com</a>> --- .../execute/negative-private-base-pointer.cl | 120 +++++++++++++++++++++ 1 file changed, 120 insertions(+) create mode 100644 tests/cl/program/execute/negative-private-base-pointer.cl diff --git a/tests/cl/program/execute/negative-private-base-pointer.cl b/tests/cl/program/execute/negative-private-base-pointer.cl new file mode 100644 index 0000000..7ee528b --- /dev/null +++ b/tests/cl/program/execute/negative-private-base-pointer.cl @@ -0,0 +1,120 @@ +/*! +[config] +name: negative private buffer base index +clc_version_min: 10 +dimensions: 1 + +[test] +kernel_name: read_write_private_base_plus_offset +name: negative base private index +global_size: 1 0 0 + +arg_out: 0 buffer int[16] \ + 0xab \ + 0xbc \ + 0xabcd \ + 0xdead \ + \ + 0xcafe \ + 0xf00d \ + 0xababfeed \ + 0xca00fe \ + \ + 0xb00feed \ + 0xca00fe \ + 0xfeedbeef \ + 0xfe \ + \ + 0xbe00fe \ + 0xabcdef \ + 0xbeef \ + 0xde + + +arg_in: 1 buffer int[16] \ + -1 \ + -1 \ + -4 \ + -4 \ + \ + -3 \ + -4 \ + -2 \ + -115 \ + \ + -109 \ + -1015 \ + -1011 \ + -1020 \ + \ + -1014 \ + -137 \ + -151 \ + -40 + +!*/ + +#if 0 + 0xab \ + 0xbc \ + 0xf00d \ + 0xdead \ + 0xcafe \ + 0xabcd \ + 0xababfeed \ + 0xca00fe \ + 0xb00feed \ + 0xca00fe \ + 0xfeedbeef \ + 0xfe \ + 0xbe00fe \ + 0xabcdef \ + 0xbeef \ + 0xde +#endif + +kernel void read_write_private_base_plus_offset(global int* out, global int* in) +{ + volatile int alloca[16]; </blockquote> does this need to be volatile? other than that: Reviewed-by: Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" class="">jan.vesely@rutgers.edu</a> <<a href="mailto:jan.vesely@rutgers.edu" class="">mailto:jan.vesely@rutgers.edu</a>>> Jan </blockquote> Yes, otherwise the private memory access will be trivially optimized out defeating the point of the test </blockquote> I don't get the trivial part. what would that be optimized to? the indices are using values from input buffer (therefore unknown), so it cannot directly match the constants to corresponding position in out buffer. Jan </blockquote> This could be replaced with a series of selects or hit the move to LDS optimization </blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">right, thanks. I didn't consider move to LDS.<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">last question. what's the purpose of that #if 0 block?<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Jan<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote></div> <div class=""> </div><div class="">I think it was just other values I was going to test but then never finished them</div></body></html>