<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <meta content="text/html; charset=UTF-8"> <style type="text/css" style="">  </style> <div dir="ltr"> <div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif"> <p>Looks great. <br> </p> <p><br> </p> <p>Reviewed-by: Neha Bhende<bhenden@vmware.com></p> <p><br> </p> <p>I suppose, we will also need similar fix in <span>arb-provoking-vertex-render as well</span><br> </p> <p><br> </p> <div id="x_Signature"> <div id="x_divtagdefaultwrapper" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols"> <p>Regards,</p> <p>Neha<br> </p> </div> </div> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Brian Paul <brianp@vmware.com><br> <b>Sent:</b> Monday, July 17, 2017 11:28:54 AM<br> <b>To:</b> piglit@lists.freedesktop.org<br> <b>Cc:</b> Charmaine Lee; Neha Bhende; Brian Paul<br> <b>Subject:</b> [PATCH] arb_provoking_vertex: fix quads-follow-provoking-vertex test</font> <div> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">Querying GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION is illegal in<br> GL 3.2 and later.<br> <br> Check the GL version to determine the expected error. Note that the<br> test says config.supports_gl_core_version = 32. With NVIDIA's driver<br> we get a 3.2 context but with Mesa we get a 3.3 context.<br> ---<br> .../arb_provoking_vertex/quads-follow-provoking-vertex.c | 13 +++++++++++--<br> 1 file changed, 11 insertions(+), 2 deletions(-)<br> <br> diff --git a/tests/spec/arb_provoking_vertex/quads-follow-provoking-vertex.c b/tests/spec/arb_provoking_vertex/quads-follow-provoking-vertex.c<br> index 02e03ee..91a18ce 100644<br> --- a/tests/spec/arb_provoking_vertex/quads-follow-provoking-vertex.c<br> +++ b/tests/spec/arb_provoking_vertex/quads-follow-provoking-vertex.c<br> @@ -45,11 +45,20 @@ piglit_init(int argc, char **argv)<br> {<br> bool pass = true;<br> GLboolean followsProvoking = false;<br> + GLint major, minor;<br> + GLenum expected_error;<br> +<br> + glGetIntegerv(GL_MAJOR_VERSION, &major);<br> + glGetIntegerv(GL_MINOR_VERSION, &minor);<br> + printf("GL version: %d.%d\n", major, minor);<br> +<br> + expected_error =<br> + (major * 10 + minor > 32) ? GL_INVALID_ENUM : GL_NO_ERROR;<br> <br> glGetBooleanv(GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION,<br> - &followsProvoking);<br> + &followsProvoking);<br> <br> - pass = piglit_check_gl_error(GL_INVALID_ENUM) && pass;<br> + pass = piglit_check_gl_error(expected_error) && pass;<br> <br> piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);<br> }<br> -- <br> 1.9.1<br> <br> </div> </span></font> </body> </html>