<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 9, 2017 at 12:27 AM, Iago Toral Quiroga <span dir="ltr"><<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">TextureStorage* functions should produce INVALID_OPERATION instead<br>
of INVALID_ENUM when the target is not valid.<br>
---<br>
 tests/spec/arb_direct_state_<wbr>access/<wbr>getcompressedtextureimage.c | 2 +-<br>
 tests/spec/arb_direct_state_<wbr>access/gettextureimage-<wbr>targets.c   | 2 +-<br>
 2 files changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/tests/spec/arb_direct_state_<wbr>access/<wbr>getcompressedtextureimage.c b/tests/spec/arb_direct_state_<wbr>access/<wbr>getcompressedtextureimage.c<br>
index 7c4a92739..4206a4714 100644<br>
--- a/tests/spec/arb_direct_state_<wbr>access/<wbr>getcompressedtextureimage.c<br>
+++ b/tests/spec/arb_direct_state_<wbr>access/<wbr>getcompressedtextureimage.c<br>
@@ -175,7 +175,7 @@ getTexImage(bool doPBO, GLenum target, GLubyte *data,<br>
                        glTextureStorage3D(name, 1, internalformat,<br>
                                           IMAGE_WIDTH, IMAGE_HEIGHT,<br>
                                           num_faces);<br>
-                       pass &= piglit_check_gl_error(GL_<wbr>INVALID_ENUM);<br>
+                       pass &= piglit_check_gl_error(GL_<wbr>INVALID_OPERATION);<br>
                }<br>
                glTextureStorage2D(name, 1, internalformat,<br>
                                   IMAGE_WIDTH, IMAGE_HEIGHT);<br>
diff --git a/tests/spec/arb_direct_state_<wbr>access/gettextureimage-<wbr>targets.c b/tests/spec/arb_direct_state_<wbr>access/gettextureimage-<wbr>targets.c<br>
index a0f48d2d2..4ebb73f59 100644<br>
--- a/tests/spec/arb_direct_state_<wbr>access/gettextureimage-<wbr>targets.c<br>
+++ b/tests/spec/arb_direct_state_<wbr>access/gettextureimage-<wbr>targets.c<br>
@@ -135,7 +135,7 @@ getTexImage(bool doPBO, GLenum target, GLubyte data[][IMAGE_SIZE],<br>
                        glTextureStorage3D(name, 1, internalformat,<br>
                                           IMAGE_WIDTH, IMAGE_HEIGHT,<br>
                                           num_faces);<br>
-                       pass = piglit_check_gl_error(GL_<wbr>INVALID_ENUM) && pass;<br>
+                       pass = piglit_check_gl_error(GL_<wbr>INVALID_OPERATION) && pass;<br>
                }<br>
                /* This is legal. */<br>
                glTextureStorage2D(name, 1, internalformat,<br>
<span class="gmail-HOEnZb"><font color="#888888">--<br>
2.11.0<br>
<br>
______________________________<wbr>_________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/piglit" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/piglit</a></font></span></blockquote><div> </div></div>Reviewed-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br></div></div>